Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect variable length string data type creation #192

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Fix incorrect variable length string data type creation #192

merged 2 commits into from
Sep 26, 2024

Commits on Sep 26, 2024

  1. Add handling for string types in data type character code 

    Previously, the method did not account for string length. This change includes a condition to directly return string types without conversion. Additionally, comments were added for clarity on different data type sections.
    Altay Sansal committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    2d60446 View commit details
    Browse the repository at this point in the history

  2. Refactor string type handling in SEGY format schema 

    Changed the condition from checking 'value' to 'name' for strings. Modified the return statement to ensure proper string conversion. This improves readability and aligns with the updated specification.
    Altay Sansal committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    172db53 View commit details
    Browse the repository at this point in the history