Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fee -> feeSubunits in README.md #114

Conversation

SiennaSaito
Copy link
Contributor

@SiennaSaito SiennaSaito commented Jul 12, 2023

#105

Updates references to fee in the readme to match types.ts.
This is a small portion of the work needed to update the readme before the schema is also changed to match.

@michaelneale
Copy link
Contributor

thanks @SiennaSaito - wonder given that the types are now more rigorously defined if we could make the README automatically updated (or perhaps automated in some other way to not be repeated? if you have any ideas).

@michaelneale michaelneale merged commit 5641d00 into TBD54566975:main Jul 12, 2023
3 checks passed
@SiennaSaito
Copy link
Contributor Author

Thanks @michaelneale!

If we're happy with adding the descriptions for each property to types.js, we could come up with a script that prints each type into a table and cats to stdout.

That'd get you 80% of the way there without having to worry about CI and templates etc.
If you wanted to hook it up with CI later then you could have CI update the readme automatically with each merge to main.

I'll spin up an issue so we can talk about it more ☀️

@SiennaSaito
Copy link
Contributor Author

SiennaSaito commented Jul 12, 2023

Issue created - #115

SiennaSaito added a commit to SiennaSaito/tbdex-protocol that referenced this pull request Jul 19, 2023
SiennaSaito added a commit to SiennaSaito/tbdex-protocol that referenced this pull request Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants