[js] Fee has dropped off Payin/outMethodResponse - add it back in

[phoebe-lew]

No description provided.

[SiennaSaito]

Looks like PaymentMethod in types.js:33 has a feeSubunits property which doesn't seem to be reflected in either ./json-schemas/definitions.json or ./json-schemas/tbdex-message.schema.json.

Based off the readme fee was a dictionary but feeSubunits is a nullable String. Feels like they both contain the same info though.
Is feeSubunits the replacement for fee or should they be seperate things? 🤔

[SiennaSaito]

Also, yo! 😎 🌻

[phoebe-lew]

Hi @SiennaSaito ! We just did a bigo refactor of the JS types this morning. the json schemas are sadly very out of touch with the types right now. Right now, the JS types should be considered the source of truth and we need to refactor the schemas (per #99, which is actually ALSO poorly named because the readme has not been updated to align with the JS changes)

[SiennaSaito]

Okay sick! I'm running low on secret time today but I'll refresh at 4 PM, see if anything has changed and then make a list of things to change to match the JS types 🥸

[SiennaSaito]

Alright - here's a small PR to update the readme with feeSubunits - let me know if this is on the right track.
#114

If that looks like it's on the right track then I'll put together a diff between the readme and types.js.

[phoebe-lew]

Fee added back in in #111