Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes #111

Merged
merged 5 commits into from
Jul 8, 2023
Merged

Changes #111

merged 5 commits into from
Jul 8, 2023

Conversation

mistermoe
Copy link
Member

Changes

  • use PresentationDefinition as value of kycRequirements instead of a JWT
    • there's really no good reason to return a JWT. we don't need cryptographic integrity here given that the entire message is signed by the PFI's DID
  • change paymentPresentationDefinitionJwt to requiredPaymentDetails
  • use JsonSchema as value of requiredPaymentDetails
    • using PD's to collect payment details from Alice ends up being problematic given the expected flow of: "use VC that matches PD. if none present, render a form to collect necessary data, issue self-signed cred with input data. send self-signed VC." The 2nd time around, the VC generated as a byproduct of not having any will automatically be used and that may not be Alice's desired behavior (imagine that alice wants to use an entirely different btc address the 2nd time she uses DIDPay). Instead, we can just return a json schema. this json schema can be used to render a form every time. Alice's input data can then be sent in the RFQ as paymentDetails. The PFI can then validate the payment details provided against the requiredPaymentDetails json schema sent in the offering.
  • change paymentVerifiablePresentationJwt to paymentDetails
  • use generic object as value of paymentDetails.
    • see requiredPaymentDetails explaination
  • fix Status enum to serialize as string values instead of int values
  • start fixing json schemas
  • temporarily disable out validator tests
    • need to figure out how to validate offerings and tbdex messages

* use `PresentationDefinition` as value of `kycRequirements`
* change `paymentPresentationDefinitionJwt` to `requiredPaymentDetails`
* change `paymentVerifiablePresentationJwt` to `paymentDetails`
* fix `Status` enum to serialize as string values instead of int values
* start fixing json schemas
* temporarily disable out validator tests
@@ -15,15 +21,15 @@ export interface Offering {
baseFeeDollars?: string
minDollars: string
maxDollars: string
kycRequirements: string
kycRequirements: PresentationDefinitionV2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this lock all tbdex users into a pex depenency?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*JS tbdex users

@phoebe-lew phoebe-lew merged commit fcc3dd4 into main Jul 8, 2023
3 checks passed
@phoebe-lew phoebe-lew deleted the changes branch July 8, 2023 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants