Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not show branding if setting is false-y #877

Merged
merged 1 commit into from
Sep 17, 2024
Merged

fix: do not show branding if setting is false-y #877

merged 1 commit into from
Sep 17, 2024

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Sep 17, 2024 •
edited
Loading

Overview

Be able to hide branding bar just by setting PORAL_BRANDING to false.

Related

Changes

  • changed template logic else to an elif

Testing

  1. Set PORTAL_BRANDING = False.
  2. Load website.
  3. Verify branding bar markup is not rendered.
    (Best to test on a site that is not hiding branding bar via CSS.)

UI

before after
BEFORE AFTER

Note

This site hides branding bar via CSS, so I test for markup presence.

@wesleyboar wesleyboar marked this pull request as ready for review September 17, 2024 19:52
@wesleyboar wesleyboar changed the title feat: do not show branding if setting is false-y fix: do not show branding if setting is false-y Sep 17, 2024
@wesleyboar wesleyboar merged commit 1f40cca into main Sep 17, 2024
@wesleyboar wesleyboar deleted the feat/do-not-show-branding-if-setting-is-falsey branch September 17, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wesleyboar