Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CMD-165 custom branding via setting #841

Merged
merged 9 commits into from
Jul 24, 2024

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Jul 5, 2024

Overview / Changes

  • Deprecate setting BRANDING.
  • Add setting PORTAL_BRANDING.
  • Add _settings/brandings.py.

Related

Testing

New Settings

  1. Do not have BRANDING in taccsite_cms/settings_local.py.
  2. Load CMS in browser.
  3. Verify branding is TACC, UTexas.

Old Setting

  1. Add BRANDING to taccsite_cms/settings_local.py:

    Code
    TACC_BRANDING = [
        "tacc",
        "site_cms/img/org_logos/tacc-white.png",
        "branding-tacc",
        "https://www.tacc.utexas.edu/",
        "_blank",
        "TACC Logo",
        "anonymous",
        "True"
    ]
    UTEXAS_BRANDING = [
        "utexas",
        "site_cms/img/org_logos/utaustin-white.png",
        "branding-utaustin",
        "https://www.utexas.edu/",
        "_blank",
        "University of Texas at Austin Logo",
        "anonymous",
        "True"
    ]
    NSF_BRANDING = [
        "nsf",
        "site_cms/img/org_logos/nsf-white.png",
        "branding-nsf",
        "https://www.nsf.gov/",
        "_blank",
        "NSF Logo",
        "anonymous",
        "True"
    ]
    BRANDING = [ NSF_BRANDING, UTEXAS_BRANDING, TACC_BRANDING ]
  2. Load CMS in browser.

  3. Verify branding is NSF, UTexas, TACC.

Custom Setting

  1. Do not have BRANDING in taccsite_cms/settings_local.py.

  2. Use PORTAL_BRANDING in taccsite_cms/settings_local.py with different order:

    Code
    from taccsite_cms._settings.branding import *
    
    PORTAL_BRANDING = [ PORTAL_BRANDING_NSF, PORTAL_BRANDING_UTEXAS, PORTAL_BRANDING_TACC ]
  3. Load CMS in browser.

  4. Verify branding is NSF, UTexas, TACC.

UI

Core-CMS

new old
standard settings_local BRANDING
standard custom / local
standard local

@wesleyboar wesleyboar changed the title Feat/cmd 165 custom branding via setting feat: CMD-165 custom branding via setting Jul 5, 2024
@wesleyboar wesleyboar added invalid This doesn't seem right and removed invalid This doesn't seem right labels Jul 16, 2024
@wesleyboar wesleyboar merged commit 8f2c470 into main Jul 24, 2024
@wesleyboar wesleyboar deleted the feat/CMD-165-custom-branding-via-setting branch July 24, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant