fix: load fa icons even if no portal #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do not want FA icons, but there is at least one usage. Usage: Frontera homepage, "(→) See All News"
|
I keep loosing tiny bits of time to this bug, because I forget why it happens, poke around, realize why it happens, then never fix it. |
wesleyboar
added a commit
that referenced
this pull request
Jun 28, 2022
We do not want FA icons, but there is at least one usage. Usage: Frontera homepage, "(→) See All News"
wesleyboar
added a commit
that referenced
this pull request
Jul 6, 2022
* fix: load fa icons even if no portal (#504) We do not want FA icons, but there is at least one usage. Usage: Frontera homepage, "(→) See All News" * feat(css): drop .o-site for simple sticky footer trick 1. Do not use o-site class in markup and do not import o-site styles. 2. Install core-styles that makes footer sticky in a simpler way. For: https://jira.tacc.utexas.edu/browse/FP-1665 * fix(css, submod): migration, no add footer margin FP-1665 will fix end-of-page padding fro old and new sites. Thus, no need for old solution, which would add excess space. For: https://jira.tacc.utexas.edu/browse/FP-1665 * fix(core-styles): load latest for fp-1665 For: https://jira.tacc.utexas.edu/browse/FP-1665 * chore(core-styles): v0.6.0-beta.3 (via gitpkg) Install @tacc/v0.6.0-beta.3 via https://gitpkg.now.sh to test FP-1665. For: https://jira.tacc.utexas.edu/browse/FP-1665 * fix(core-styles): v0.6.0-beta.3 (via gitpkg) new * fix(core-styles): v0.6.0-beta.3 (via gitpkg), 3rd * fix(core-styles): v0.6.0-beta.3 (via npm) * chore(submod): merged TACC/Core-CMS-Resources#147 TACC/Core-CMS-Resources#147 For: #506
wesleyboar
added a commit
that referenced
this pull request
Jul 6, 2022
* feat(tup-271): use TACC/tup-ui:/libs/core-styles * fix(tup-271): simplify PR diff * feat: install core-styles via npm at v0.6.1-alpha * docs(README): change all [Core Styles] links * feat: install [email protected] * chore(core-styles): install 0.6.0-beta * fix(core-styles): template sample markup symlinks * After/tup 271 fp 1663 system spec figure styles (#503) * fix(core-styles): s-system-specs unset figure css * fix(core-styles): no figure css (only .figure css) - Do not load elements/figure.css. - Load core-styles that deleted elements/figure.css (and moved its styles). * fix(core-styles): update temporary pacakge url * chore: inconsequential change to bust docker cache * Revert "chore: inconsequential change to bust docker cache" This reverts commit bd61cdc. * chore(core-styles): v0.6.0-beta.1 * After/tup 271 fp 1666 frontera header hidden (#505) * chore(core-styles): v0.6.0-beta.2 * fix: fp-1666 no load what v0.6.0-beta.1 deleted FP-1666 uses v0.6.0-beta.2 which includes v0.6.0-beta.1. This eases deploy and testing of FP-1663, FP-1666, and FP-1665. But v0.6.0-beta.1 removed 'elements/figure.css'; build error on load. Must not merge FP-1666 (v0.6.0-beta.2) before FP-1663 (v0.6.0-beta.1). * After/tup 271 fp 1665 excess space above footer (#506) * fix: load fa icons even if no portal (#504) We do not want FA icons, but there is at least one usage. Usage: Frontera homepage, "(→) See All News" * feat(css): drop .o-site for simple sticky footer trick 1. Do not use o-site class in markup and do not import o-site styles. 2. Install core-styles that makes footer sticky in a simpler way. For: https://jira.tacc.utexas.edu/browse/FP-1665 * fix(css, submod): migration, no add footer margin FP-1665 will fix end-of-page padding fro old and new sites. Thus, no need for old solution, which would add excess space. For: https://jira.tacc.utexas.edu/browse/FP-1665 * fix(core-styles): load latest for fp-1665 For: https://jira.tacc.utexas.edu/browse/FP-1665 * chore(core-styles): v0.6.0-beta.3 (via gitpkg) Install @tacc/v0.6.0-beta.3 via https://gitpkg.now.sh to test FP-1665. For: https://jira.tacc.utexas.edu/browse/FP-1665 * fix(core-styles): v0.6.0-beta.3 (via gitpkg) new * fix(core-styles): v0.6.0-beta.3 (via gitpkg), 3rd * fix(core-styles): v0.6.0-beta.3 (via npm) * chore(submod): merged TACC/Core-CMS-Resources#147 TACC/Core-CMS-Resources#147 For: #506 * chore(core-styles): install 0.6.0 * chore(core-styles): v3.7.11 * fix(changelog): typo, 3.7._ to 3.7.11 * fix(protx): wrong path to core-styles theme * fix(tup): wrong path to core-styles theme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Support icons even if Portal is not active.
Related
Changes
Testing
INCLUDES_CORE_PORTALset toFalse.Screenshots
Notes
We do not want FA icons, but there is at least one usage.
Usage: Frontera homepage, "(→) See All News"