After/tup 271 fp 1665 excess space above footer (#506)

* fix: load fa icons even if no portal (#504) We do not want FA icons, but there is at least one usage. Usage: Frontera homepage, "(→) See All News" * feat(css): drop .o-site for simple sticky footer trick 1. Do not use o-site class in markup and do not import o-site styles. 2. Install core-styles that makes footer sticky in a simpler way. For: https://jira.tacc.utexas.edu/browse/FP-1665 * fix(css, submod): migration, no add footer margin FP-1665 will fix end-of-page padding fro old and new sites. Thus, no need for old solution, which would add excess space. For: https://jira.tacc.utexas.edu/browse/FP-1665 * fix(core-styles): load latest for fp-1665 For: https://jira.tacc.utexas.edu/browse/FP-1665 * chore(core-styles): v0.6.0-beta.3 (via gitpkg) Install @tacc/v0.6.0-beta.3 via https://gitpkg.now.sh to test FP-1665. For: https://jira.tacc.utexas.edu/browse/FP-1665 * fix(core-styles): v0.6.0-beta.3 (via gitpkg) new * fix(core-styles): v0.6.0-beta.3 (via gitpkg), 3rd * fix(core-styles): v0.6.0-beta.3 (via npm) * chore(submod): merged TACC/Core-CMS-Resources#147 TACC/Core-CMS-Resources#147 For: #506
TACC · Jul 6, 2022 · 28cbee6 · 28cbee6
1 parent f5d6cdb
commit 28cbee6
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 21 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -9,7 +9,7 @@
     "npm": "^8.5.5"
   },
   "devDependencies": {
-    "@tacc/core-styles": "^0.6.0-beta.2",
+    "@tacc/core-styles": "^0.6.0-beta.3",
     "minimist": "^1.2.6"
   },
   "repository": "[email protected]:TACC/Core-CMS.git",

diff --git a/taccsite_cms/static/site_cms/css/src/_migrations/v1_v2/main.portal.css b/taccsite_cms/static/site_cms/css/src/_migrations/v1_v2/main.portal.css
@@ -20,10 +20,3 @@ body {
   /* min-height: 100%; */
   /* position: relative; */
 }
-
-/* … */
-
-footer {
-  /* … */
-  margin-top: 1em;
-}
diff --git a/taccsite_cms/static/site_cms/css/src/site.css b/taccsite_cms/static/site_cms/css/src/site.css
@@ -24,7 +24,6 @@
 @import url("_imports/objects/o-grid.css");
 @import url("_imports/objects/o-offset-content.css");
 @import url("_imports/objects/o-section.css");
-@import url("_imports/objects/o-site.css");
 
 /* COMPONENTS */
 @import url("_imports/components/c-card.css");

diff --git a/taccsite_cms/templates/base.html b/taccsite_cms/templates/base.html
@@ -46,14 +46,14 @@
   {% render_block "css" %}
 </head>
 
-<body class="o-site  {% block page_type_class %}{% endblock page_type_class %}">
+<body class="{% block page_type_class %}{% endblock page_type_class %}">
   {% cms_toolbar %}
 
-  <header class="o-site__head">
+  <header>
     {% include "header.html" %}
   </header>
 
-  <main id="cms-content" class="o-site__body">
+  <main id="cms-content">
   {% block content %}
 
     {# To allow extra Container in page structure by hiding extra padding #}
@@ -70,7 +70,7 @@
   {% endblock content %}
   </main>
 
-  <footer class="c-footer  s-footer  o-site__foot">
+  <footer class="c-footer  s-footer">
   {% block footer %}
 
     {% static_placeholder "footer-content" or %}

diff --git a/taccsite_custom b/taccsite_custom