Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FP-1496: CSS Build to Core-Styles #448

Merged
merged 149 commits into from
Apr 6, 2022
Merged

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Mar 1, 2022

Overview

Migrate most source CSS and build logic to new repo.

Related

Requires

Changes

  • Replace .env with passing project name through Docker.
  • Add CSS version comment by passing build id through Docker.
  • Update README's.
  • Build CSS via https://github.com/TACC/Core-Styles.
  • Delete cruft i.e. settings.json, "freeze variables", dependencies.
  • Delete source CSS.
  • Add migration CSS.
  • Update symlinks.

Testing

Remote

Confirm server deploys succeed. (click for links to jobs & servers)
  • Does website load?
  • Do all Core stylesheets load?
  • Do per-project (if any) stylesheets load?
  • Is UI unchanged? (Compare to prod.)
  • Is appropriate ID is in comment at top of each TACC stylesheet e.g. v3.5.2-...-g.......
  • Are the pattern library markup symlinks working? (o-section, o-grid, c-callout)
Site Build Deploy Server Note
Core #573 #1327 dev since Core-Styles rename
Core #554 #1290 dev
Frontera #551 #1284 dev
ProTX #555 #1292 pprd
3Dem #552 #1283 staging
TUP #556 #1291 dev
A2CPS #553 #1282 pprd
UTRC #557 #1293 pprd
Brainmap #558 #1294 pprd

Local

Confirm identical build output for project(s) on main branch versus this branch.

See How to Test Major Changes to CSS.

Notes

To force HTTPS, git+https://[email protected] is prefixed to package.json devDependency https://github.com/TACC/Core-Styles. To learn why, see npm/cli#2610.

wesleyboar and others added 30 commits February 4, 2022 14:15
@wesleyboar wesleyboar removed the request for review from taoteg March 28, 2022 00:17
@wesleyboar wesleyboar added the priority ▲▲ Very high priority label Mar 28, 2022
@rstijerina
Copy link
Member

From https://dev.fronteraweb.tacc.utexas.edu/user-guide/

GET https://dev.fronteraweb.tacc.utexas.edu/static/frontera-cms/css/build/site.header.css net::ERR_ABORTED 404

Is this related to changes in this PR?

Copy link
Member Author

@wesleyboar wesleyboar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To Do

@wesleyboar
Copy link
Member Author

Is this related to changes in this PR? — @rstijerina

Nope. Related to #383. Ticket created: FP-1595.

Copy link
Member

@rstijerina rstijerina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work! 🚀

@wesleyboar wesleyboar merged commit 7a6792b into main Apr 6, 2022
@wesleyboar wesleyboar deleted the test/core-styles--solution-b branch April 6, 2022 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority ▲▲ Very high priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants