-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FP-1496: CSS Build to Core-Styles #448
Conversation
2f36244
to
00258f4
Compare
before, themes weren't working; now, themes work
before, project configs were assumed; now, they aren't fixes fronteraa-cms build fail (it had no project config)
These are redundant. The filename already shows the filename.
From https://dev.fronteraweb.tacc.utexas.edu/user-guide/
Is this related to changes in this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To Do
- merge
main
- change tacc-wbomar to TACC (Core-Styles was moved)
- determine whether user-guide header.css file not found issue is related or not (and if so, fix it)
- ✓ not related; cruft from FP-1287: Redesign & Refactor Search Bar #383; see FP-1595
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work! 🚀
Overview
Migrate most source CSS and build logic to new repo.
Related
Requires
Changes
.env
with passing project name through Docker.README
's.settings.json
, "freeze variables", dependencies.Testing
Remote
Confirm server deploys succeed. (click for links to jobs & servers)
v3.5.2-...-g.......
CoreLocal
Confirm identical build output for project(s) on
main
branch versus this branch.See How to Test Major Changes to CSS.
Notes
To force HTTPS,
git+https://[email protected]
is prefixed topackage.json
devDependency https://github.com/TACC/Core-Styles. To learn why, see npm/cli#2610.