Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FP-1502: Fix Callout Title Height #441

Merged
merged 1 commit into from
Feb 10, 2022
Merged

FP-1502: Fix Callout Title Height #441

merged 1 commit into from
Feb 10, 2022

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Feb 10, 2022

Overview

Change Callout pattern's grid's row and column dimensions to fix FP-1502 bug.

Issues

FP-1502

Screenshots

State Image
Before FP-1502 Broken
After FP-1502 Fixed

Testing

  1. Create a Callout pattern (.c-callout with img and h2 and p).
  2. Ensure the image is taller than the description and title together.
  3. Confirm no excess vertical space between title and description.

@wesleyboar
Copy link
Member Author

wesleyboar commented Feb 10, 2022

Tiny UI hotfix for last release that has not gone through pre-deploy test yet. Merging it now to avoid creating prod bug.

@wesleyboar wesleyboar merged commit 4073fc5 into main Feb 10, 2022
@wesleyboar wesleyboar deleted the fix/FP-1502 branch February 10, 2022 22:05
wesleyboar added a commit that referenced this pull request Feb 10, 2022
wesleyboar added a commit to TACC/Core-Styles that referenced this pull request Feb 14, 2022
wesleyboar added a commit to TACC/Core-CMS-Resources that referenced this pull request Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant