-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-245/FP-1097: v1–v2 Migration Stylesheet #59
Changes from all commits
323c7e8
702e0a1
39457c8
ec660de
e32c935
8fa9c27
4b353b7
2848d6d
9c2a2f7
4fe6ad7
25f3575
03154f9
fc4ad95
43fc53a
57fa7a3
d1a1845
b14e0ee
a9c15b1
8c485eb
cd5d6b0
f2f219d
5ad8e04
721a63c
ccaecb4
9241253
e318e73
516361a
347aa0c
bdcaa50
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
# Why Does `__init.py__ Exist Here? | ||
|
||
Locally, this file is unnecessary. But when deployed to a remote server, it prevents an error. | ||
|
||
## Reference | ||
|
||
- https://github.com/TACC/Core-Portal-Deployments/commit/f2ea0d094da19b9942288fb5660fe00fb0e6778b | ||
- https://github.com/TACC/Core-Portal-Deployments/commit/62f9d225c5049f29daedc95af2da546b83c9a474 |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
# TACC CMS Per-Site Resources - Shared - Stylesheets | ||
|
||
See [Core CMS Stylesheets `README.md`][core-css-readme]. | ||
|
||
## Naming Format | ||
|
||
| Format | Description | | ||
| :- | :- | | ||
| [...][core-css-readme-naming] | [...][core-css-readme-naming] | ||
| `migrate.*.css` | styles that apply to websites that have been migrated[^1] | ||
|
||
[^1]: When sensible, use the migration folder name, i.e. `migrate.v1_v2.css`. | ||
|
||
[core-css-readme]: https://github.com/TACC/Core-CMS/blob/main/taccsite_cms/static/site_cms/css/src/README.md | ||
[core-css-readme-naming]: https://github.com/TACC/Core-CMS/blob/main/taccsite_cms/static/site_cms/css/src/README.md#naming-format |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
# TACC CMS - Stylesheets - Migrations | ||
|
||
ORGANIZE STYLES HERE! | ||
|
||
These folders' styles are only to be imported by other stylesheets. | ||
|
||
CMS websites that were migrated from earlier instances may need these styles. | ||
|
||
## Rules | ||
|
||
1. Folders __must__ include any top-of-file comments from source file. | ||
1. Folders __must__ be [named with appropriate format](#Naming%20Format). | ||
1. Files __should__ [comment on purpose and means of acquisition](#Documentation%20Format). | ||
1. Files __must__ include a top-of-file comments (from source file or by TACC). | ||
1. Files (except this document) __must__ be in a folder. | ||
|
||
## Documentation Format | ||
|
||
```css | ||
/* | ||
Pre-2020 Django CMS Bootstrap 3.3.7 | ||
HOW: https://dev.help.com/some-tool | ||
HOW: Included code that ... | ||
HOW: Included code that ... (because ...) e.g.: | ||
- ... | ||
HOW: Did NOT incude code that ... | ||
SRC: https://bitbucket.org/taccaci/frontera/src/master/client/css/bootstrap.min.css | ||
*/ | ||
``` | ||
|
||
## Naming Format | ||
|
||
| Format | Description | | ||
| :- | :- | | ||
| `A_B/` | from old "A" to new "B"[^1] | ||
| `v1_v2/` | from Core__V1__ CMS (pre-2020) to Core__V2__ CMS (2020+) | ||
|
||
[^1]: Where "A" and "B" represent a version, or historical state, of the CMS. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
/* | ||
CoreV1 Portal Stylesheet `portal.css` | ||
HOW: Manually find and retain code that is still used | ||
SRC: https://bitbucket.org/taccaci/frontera/src/master/client/css/portal.css | ||
*/ | ||
|
||
/*! | ||
* CoreV1 Portal Stylesheet `portal.css` | ||
* https://bitbucket.org/taccaci/frontera/src/master/client/css/portal.css | ||
* 59e345f | ||
*/ | ||
|
||
/* … */ | ||
|
||
body { | ||
font-family: 'Roboto', sans-serif; | ||
|
||
/* TACC: Disabled */ | ||
/* FAQ: Wesley forgot why; this and more may be deleted anyway */ | ||
/* min-height: 100%; */ | ||
/* position: relative; */ | ||
} | ||
|
||
/* … */ | ||
|
||
footer { | ||
/* … */ | ||
margin-top: 1em; | ||
} | ||
Comment on lines
+26
to
+29
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Notice |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
/* DO NOT ADD STYLES HERE; ONLY IMPORT OTHER STYLESHEETS */ | ||
|
||
@import url("_migrations/v1_v2/bootstrap.3.3.7.css"); | ||
@import url("_migrations/v1_v2/angular-material.1.1.8.css"); | ||
@import url("_migrations/v1_v2/main.portal.css"); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
<p> <!-- To mimic 2020 site whitespace in Cards with reusable tracable code --></p> |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,114 @@ | ||
/* | ||
A2CPS Migration Styles | ||
HOW: Manually find discrepencies in UI that seem specific to A2CPS | ||
*/ | ||
|
||
/*! | ||
* A2CPS Migration Styles | ||
*/ | ||
|
||
|
||
|
||
|
||
|
||
/* ELEMENTS */ | ||
|
||
/* Table Content */ | ||
|
||
table, | ||
td, | ||
th { | ||
/* To mimic 2020 site by restoring browser default */ | ||
border-color: inherit; /* override `site.css` */ | ||
} | ||
|
||
/* To mimic unscoped styles from Angular component that v1 CMS assumes exist */ | ||
/* SEE: https://bitbucket.org/taccaci/frontera/src/8167403/client/src/angular/data_depot/projects/components/project-meta/project-meta.css?#project-meta.css-34 */ | ||
td { | ||
padding-right: 2.25em; | ||
padding-bottom: 0.5em; | ||
} | ||
|
||
|
||
|
||
|
||
|
||
/* COMPONENTS */ | ||
|
||
|
||
|
||
/* COMPONENTS: TACC */ | ||
|
||
/* Footer */ | ||
|
||
.c-footer { | ||
/* To mimic 2020 site `#footer` styles */ | ||
margin: 0; | ||
} | ||
|
||
|
||
|
||
/* COMPONENTS: Bootstrap */ | ||
|
||
/* Cards */ | ||
|
||
/* To mimic 2020 site faux cards via Bootstrap cards */ | ||
/* SEE: https://a2cps.org/patients/.../ */ | ||
/* SEE: https://a2cps.org/researchers/ */ | ||
/* FAQ: A faux cards was a <div> (card) with two <p>'s (header, body) */ | ||
.card { | ||
/* To clear `.card` styles */ | ||
border-radius: 0; | ||
|
||
/* To mimic header <p> (from inline styles) */ | ||
margin-top: 20px; | ||
|
||
/* To mimic body <img> (from inline styles) */ | ||
margin-bottom: 20px; | ||
} | ||
|
||
.card-header { | ||
/* To mimic header <p> (from inline styles) */ | ||
padding: 15px; | ||
|
||
/* To mimic header <p>'s typography (from inline styles) */ | ||
text-align: center; | ||
font-weight: bold; | ||
font-size: 16px; | ||
} | ||
.card-header:first-child { | ||
/* To clear `.card` styles */ | ||
border-radius: 0; | ||
} | ||
|
||
.card-body { | ||
/* SEE: https://a2cps.org/connect/ */ | ||
padding: 15px; | ||
} | ||
|
||
/* To mimic faux card inline styles */ | ||
.card.bg-light .card-header, | ||
.card.bg-transparent .card-header { | ||
background-color: #DFDFDF; | ||
border-bottom-color: #DFDFDF; | ||
} | ||
.card.bg-light .card-body, | ||
.card.bg-transparent .card-body { | ||
/* SEE: https://a2cps.org/connect/ */ | ||
border-color: #DFDFDF; | ||
} | ||
|
||
/* Cards: "For ..." Pages */ | ||
.s-page-cards .card, | ||
.s-page-cards .card-header { | ||
/* To clear `.card` styles */ | ||
border: none; | ||
} | ||
.s-page-cards .card-header p { | ||
/* To prevent <p> (forced by Text plugin WYSIWIG) from breaking layout */ | ||
margin: 0; | ||
} | ||
.s-page-cards .card-body { | ||
/* To clear `.card` styles */ | ||
padding: 0; | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
/* DO NOT ADD STYLES HERE; ONLY IMPORT OTHER STYLESHEETS */ | ||
|
||
@import url("../../../../../_shared/static/css/src/migrate.v1_v2.css"); | ||
@import url("./_migrations/v1_v2/a2cps.css"); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
/* DO NOT ADD STYLES HERE; ONLY IMPORT OTHER STYLESHEETS */ | ||
|
||
@import url("../../../../../_shared/static/css/src/migrate.v1_v2.css"); |
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
/* DO NOT ADD STYLES HERE; ONLY IMPORT OTHER STYLESHEETS */ | ||
|
||
@import url("../../../../../_shared/static/css/src/migrate.v1_v2.css"); | ||
|
||
@import url("_migrations/v1_v2/frontera.css"); |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,7 +16,7 @@ | |
/* … */ | ||
|
||
/* COMPONENTS */ | ||
@import url("_imports/components/tacc.c-footer.css"); | ||
/* … */ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Explanation |
||
|
||
/* TRUMPS */ | ||
/* … */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explanation
This style has been being overwritten anyway for more than a year.