GH-245/FP-1097: v1–v2 Migration Stylesheet #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of GH-73, this component is maintained in Core.
This allows Bootstrap 4 blockquotes to be replaced by TACC blockquote.
5 tasks
Avoid this error that occurred on A2CPS ``` AttributeError: module 'taccsite_custom._shared' has no attribute 'default_app_config' ``` via Core-Portal-Deployments 91966f8. Previous attempt to avoid this was TACC/Core-CMS @ e8d864e3 — it failed
wesleyboar
commented
Jul 9, 2021
| @import url("_imports/components/tacc.c-footer.css"); | ||
| /* … */ |
There was a problem hiding this comment.
Explanation
Moved code from tacc.c-footer.css code to _migrations/v1_v2/main.portal.css.
wesleyboar
commented
Jul 9, 2021
Comment on lines
+26
to
+29
| footer { | ||
| /* … */ | ||
| margin-top: 1em; | ||
| } |
There was a problem hiding this comment.
Notice
Moved from tacc.c-footer.css to here.
wesleyboar
commented
Jul 9, 2021
Comment on lines
-1
to
-7
| /* TACC COMPONENTS: Footer */ | ||
|
|
||
| .c-footer { | ||
| /* Mimic strange style from old design ported for 2020-02 launch */ | ||
| /* FP-459: After the redesign of Frontera, remove these */ | ||
| margin-top: 1em; | ||
| } |
There was a problem hiding this comment.
Explanation
Moved to _migrations/v1_v2/main.portal.css from here.
wesleyboar
commented
Jul 9, 2021
Comment on lines
-140
to
+144
| font-size:10px; | ||
| /* Disabled by TACC */ | ||
| /* FAQ: Let TACC handle influence `rem`; this and more may be deleted anyway */ | ||
| /* font-size:10px; */ |
There was a problem hiding this comment.
Explanation
This style has been being overwritten anyway for more than a year.
wesleyboar
added a commit
that referenced
this pull request
Jul 12, 2021
This adds template, but not v1 styles. For v1 styles see #59.
|
Merging based on approval of TACC/Core-CMS#274. |
wesleyboar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
TACC/Core-CMS#274 relies on this PR.
To Do
Done
Overview
Changes
_sharedpseudo-project.migrate.*.cssand_migrations/._shared/.../_migrations/.Issues, Screenshots, Testing, Notes
See TACC/Core-CMS#274.