Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix parameter cached beetwen elaborations #182

Closed
wants to merge 1 commit into from

Conversation

Risto97
Copy link

@Risto97 Risto97 commented Jul 6, 2023

Attempt at solving #181

@coveralls
Copy link

Coverage Status

coverage: 95.065% (+0.004%) from 95.061% when pulling 7eb579f on Risto97:main into 42d877d on SystemRDL:main.

@amykyta3
Copy link
Member

This looks like it should work, but I want to take a closer look to see if there's a more correct place to fix this.
I suspect it might be better to suppress copying the cached value in Parameter._copy_for_inst() in parameter.py

amykyta3 added a commit that referenced this pull request Jul 20, 2023
@amykyta3
Copy link
Member

Yep. Turns out clearing the parameter cache in Parameter._copy_for_inst() works as well, and is a more appropriate place to handle this.

Rejecting this PR, but thank you nonetheless for looking into this!

@amykyta3 amykyta3 closed this Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants