Override parameter during elaborate, second time default parameter is used

[Risto97]

Take a look at this example:

test.rdl

addrmap test #(
    longint unsigned N = 5
    ){
    reg {name = "dummy"; field {sw = r; hw = w;} dummy[1] = 0;} dummy;
};

In test code I first override parameter N with 2, then I override for another instance with 3.
I expect print to be:
N 2
N 3

from systemrdl import RDLCompiler

rdlc = RDLCompiler()
rdlc.compile_file("test.rdl")

node = rdlc.elaborate(
        top_def_name="test",
        inst_name="new_inst",
        parameters={'N' : 2}
        ).find_by_path("new_inst")
[print(p.name, p.get_value()) for p in node.inst.parameters]

node2 = rdlc.elaborate(
        top_def_name="test",
        inst_name="new_inst2",
        parameters={'N' : 3}
        ).find_by_path("new_inst2")
[print(p.name, p.get_value()) for p in node2.inst.parameters]

What I get is:
N 2
N 5

If I remove default parameter value it works correctly and I get:
N 2
N 3

Seems like a bug?

[amykyta3]

Interesting. Yeah agree that doesn't look right.
I suspect this was missed since in nearly all the cases I use this, I only ever run the elaborate() step once. What you are doing should be supported though! Something must be leaking between elaborations.

Thanks for reporting this!

[Risto97]

I am doing weird things with the compiler honestly. But some corner cases are popping up, which is good.

I feel like the problem is the _copy_for_inst() method in component.py

[amykyta3]

Found and fixed the issue. Fix will be in the next release.