Add closeWithCollateral to SIP-135#1496
Merged
barrasso merged 13 commits intomeb-short-refactorfrom Sep 8, 2021
Merged
Conversation
jacko125
reviewed
Sep 8, 2021
jacko125
reviewed
Sep 8, 2021
added 2 commits
September 8, 2021 10:27
barrasso
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows users to close their short when repaying with collateral.
closeWithCollateralfunction that repays the loan in full, records it as closed, and transfers the remaining collateral back to the borrower.payInterestflag -> pay back theaccruedInterestin all cases.