SIP-149 Removing Binary Options from the protocol#1494
Merged
jjgonecrypto merged 4 commits intodevelopfrom Sep 6, 2021
Merged
Conversation
jjgonecrypto
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #1494 +/- ##
===========================================
- Coverage 95.63% 95.21% -0.43%
===========================================
Files 81 76 -5
Lines 1925 1733 -192
Branches 637 557 -80
===========================================
- Hits 1841 1650 -191
+ Misses 84 83 -1 Continue to review full report at Codecov.
|
jjgonecrypto
requested review from
barrasso,
dbeal-eth,
jacko125,
liamzebedee and
zyzek
and removed request for
barrasso and
dbeal-eth
liamzebedee
approved these changes
Sep 6, 2021
# Conflicts: # test/deployments/index.js
barrasso
added a commit
that referenced
this pull request
Sep 8, 2021
* Add repayAndClose * Remove extra getLoanAndAccrueInterest * SIP-149 Removing Binary Options from the protocol (#1494) * Fixes for imports around VirtualSynth to prevent issues with IERC20 (#1497) * Update short tests * Fix shorts tests on l1 fork * Fix shorts tests on l1 fork * Update ovm-ignore.json * Update ovm-ignore.json * Rename closeLoanWithCollateral Co-authored-by: Mark Barrasso <mark@synthetix.io> Co-authored-by: jj <justin@synthetix.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BinaryOption*from deployment actionsBinaryOption*contracts & associated testsBinaryOption*fromdeployment.jsonfilesNote: the actual BinaryOption contracts are still visible in each environment's
versions.jsonfor posterity