Reply support #98
Merged
Reply support #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is obviously not how a ViewModel is used, but this commit was growing a little too big for comfort.
Supplying width and height arguments are no longer required
Instead of switching between a CachedImageView and SwiftyGifView
Run blocking operations on the utility DispatchQueue to prevent hanging the main thread
* Use BetterImageView where possible to increase conciseness * Remove animation from server button when pressed (like Discord) * Make channel icon in message list header align with the official client
Newly supported types: * recipientAdd (member added to a group DM) * recipientRemove (member removed from group DM) * userPremiumGuildSub (server boosted) * userPremiumGuildSubTier1, userPremiumGuildSubTier2, userPremiumGuildSubTier3 (server boosted and achieved tiers 1, 2 or 3 respectively)
Note: Every commit from now onwards expects that Message is a class and referenced_message is of type Message.
commit c54920f Author: cxt <[email protected]> Date: Mon Aug 8 18:23:17 2022 +0000 Translated using Weblate (German) Currently translated at 98.1% (106 of 108 strings) Translation: Swiftcord/Swiftcord Translate-URL: https://hosted.weblate.org/projects/swiftcord/swiftcord/de/ commit 81cde3d Author: jnghyk <[email protected]> Date: Mon Aug 8 11:37:50 2022 +0000 Translated using Weblate (Korean) Currently translated at 100.0% (82 of 82 strings) Translation: Swiftcord/Swiftcord Translate-URL: https://hosted.weblate.org/projects/swiftcord/swiftcord/ko/ commit dfc2c03 Author: jnghyk <[email protected]> Date: Mon Aug 8 11:15:47 2022 +0000 Translated using Weblate (Korean) Currently translated at 98.7% (81 of 82 strings) Translation: Swiftcord/Swiftcord Translate-URL: https://hosted.weblate.org/projects/swiftcord/swiftcord/ko/ commit 8782877 Author: vinkwok <[email protected]> Date: Thu Aug 4 22:24:03 2022 +0800 Initial reply UI commit 0b2fc65 Author: vinkwok <[email protected]> Date: Wed Aug 10 18:38:36 2022 +0800 Optimisation: play/pause animation when required Instead of switching between a CachedImageView and SwiftyGifView
Self cannot be mutated since mutable functions don’t exist in classes, so return a new instance instead. This should fix this actions build failure.
In progress of debugging some GitHub actions issue. Also includes minor pixel-perfection improvements.
In progress of debugging some GitHub actions issue. Also includes minor pixel-perfection improvements.
No longer uses the flaky MessageInfoBarView method
commit f8b4a24 Author: vinkwok <[email protected]> Date: Thu Aug 11 17:27:31 2022 +0800 Lock DiscordKit commit hash In progress of debugging some GitHub actions issue. Also includes minor pixel-perfection improvements. commit 87bb3f2 Author: vinkwok <[email protected]> Date: Thu Aug 11 17:10:39 2022 +0800 Fix mergingWithPartialMsg: return new instance Self cannot be mutated since mutable functions don’t exist in classes, so return a new instance instead. This should fix this actions build failure. commit 0cdb7f6 Author: vinkwok <[email protected]> Date: Thu Aug 11 14:53:57 2022 +0800 Squashed commit of the following: commit c54920f Author: cxt <[email protected]> Date: Mon Aug 8 18:23:17 2022 +0000 Translated using Weblate (German) Currently translated at 98.1% (106 of 108 strings) Translation: Swiftcord/Swiftcord Translate-URL: https://hosted.weblate.org/projects/swiftcord/swiftcord/de/ commit 81cde3d Author: jnghyk <[email protected]> Date: Mon Aug 8 11:37:50 2022 +0000 Translated using Weblate (Korean) Currently translated at 100.0% (82 of 82 strings) Translation: Swiftcord/Swiftcord Translate-URL: https://hosted.weblate.org/projects/swiftcord/swiftcord/ko/ commit dfc2c03 Author: jnghyk <[email protected]> Date: Mon Aug 8 11:15:47 2022 +0000 Translated using Weblate (Korean) Currently translated at 98.7% (81 of 82 strings) Translation: Swiftcord/Swiftcord Translate-URL: https://hosted.weblate.org/projects/swiftcord/swiftcord/ko/ commit 8782877 Author: vinkwok <[email protected]> Date: Thu Aug 4 22:24:03 2022 +0800 Initial reply UI commit 0b2fc65 Author: vinkwok <[email protected]> Date: Wed Aug 10 18:38:36 2022 +0800 Optimisation: play/pause animation when required Instead of switching between a CachedImageView and SwiftyGifView commit 5d29118 Author: vinkwok <[email protected]> Date: Thu Aug 11 14:48:29 2022 +0800 Render replies to “action messages” properly Note: Every commit from now onwards expects that Message is a class and referenced_message is of type Message. commit b4e22a0 Author: vinkwok <[email protected]> Date: Thu Aug 11 13:58:50 2022 +0800 Put message rendering views in their own folder commit bbd5e1b Author: vinkwok <[email protected]> Date: Thu Aug 11 12:40:39 2022 +0800 Support more message types! Newly supported types: * recipientAdd (member added to a group DM) * recipientRemove (member removed from group DM) * userPremiumGuildSub (server boosted) * userPremiumGuildSubTier1, userPremiumGuildSubTier2, userPremiumGuildSubTier3 (server boosted and achieved tiers 1, 2 or 3 respectively) commit 36a59cd Author: vinkwok <[email protected]> Date: Thu Aug 11 11:15:07 2022 +0800 UI bugfixes and optimisations * Use BetterImageView where possible to increase conciseness * Remove animation from server button when pressed (like Discord) * Make channel icon in message list header align with the official client commit 0a44232 Author: vinkwok <[email protected]> Date: Thu Aug 11 10:39:11 2022 +0800 Major Keychain helper cleanup Run blocking operations on the utility DispatchQueue to prevent hanging the main thread commit a05f652 Author: vinkwok <[email protected]> Date: Wed Aug 10 19:03:32 2022 +0800 Fix README typo, summarise some points commit 161bc02 Author: vinkwok <[email protected]> Date: Wed Aug 10 18:38:36 2022 +0800 Optimisation: play/pause animation when required Instead of switching between a CachedImageView and SwiftyGifView commit c34cb21 Author: vinkwok <[email protected]> Date: Wed Aug 10 13:23:18 2022 +0800 Allow SwiftyGifView to be sized with .frame Supplying width and height arguments are no longer required
# Conflicts: # Swiftcord.xcodeproj/project.pbxproj # Swiftcord.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved # Swiftcord/Utils/Extensions/MessagesView+.swift # Swiftcord/Views/Message/MessageRenderViews/MessageView.swift # Swiftcord/Views/Message/MessagesView.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, you can reply to messages right from Swiftcord!