Skip to content

Commit 0b2fc65

Browse files
cryptoAlgorithmweblate
authored andcommitted
Optimisation: play/pause animation when required
Instead of switching between a CachedImageView and SwiftyGifView
1 parent bbd5e1b commit 0b2fc65

File tree

2 files changed

+69
-74
lines changed

2 files changed

+69
-74
lines changed

Swiftcord.xcodeproj/project.pbxproj

+2
Original file line numberDiff line numberDiff line change
@@ -326,6 +326,7 @@
326326
DAAFB5CB282B879200807B54 /* Double+.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "Double+.swift"; sourceTree = "<group>"; };
327327
DAB1E46928A0A59500645FCD /* CreditsView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = CreditsView.swift; sourceTree = "<group>"; };
328328
DAB1E46B28A10BB100645FCD /* BetterImageView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = BetterImageView.swift; sourceTree = "<group>"; };
329+
DAB1E47728A3788800645FCD /* SwiftyGif */ = {isa = PBXFileReference; lastKnownFileType = wrapper; name = SwiftyGif; path = ../SwiftyGif; sourceTree = "<group>"; };
329330
DAB53661285A272D00DD9857 /* OnboardingView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = OnboardingView.swift; sourceTree = "<group>"; };
330331
DAB53664285ACED100DD9857 /* GitHubAPI.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = GitHubAPI.swift; sourceTree = "<group>"; };
331332
DAB53667285AD11000DD9857 /* DiscordChannelButton.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = DiscordChannelButton.swift; sourceTree = "<group>"; };
@@ -462,6 +463,7 @@
462463
DA4A887B27C0AF3000720909 = {
463464
isa = PBXGroup;
464465
children = (
466+
DAB1E47728A3788800645FCD /* SwiftyGif */,
465467
36004E1C283D63E500F0BA73 /* .swiftlint.yml */,
466468
DA4A888627C0AF3000720909 /* Swiftcord */,
467469
DA4A891727C4B0DF00720909 /* README.md */,
Original file line numberDiff line numberDiff line change
@@ -1,77 +1,70 @@
11
{
2-
"pins" : [
3-
{
4-
"identity" : "appcenter-sdk-apple",
5-
"kind" : "remoteSourceControl",
6-
"location" : "https://github.com/microsoft/appcenter-sdk-apple",
7-
"state" : {
8-
"revision" : "b2dc99cfedead0bad4e6573d86c5228c89cff332",
9-
"version" : "4.4.3"
2+
"object": {
3+
"pins": [
4+
{
5+
"package": "AppCenter",
6+
"repositoryURL": "https://github.com/microsoft/appcenter-sdk-apple",
7+
"state": {
8+
"branch": null,
9+
"revision": "b2dc99cfedead0bad4e6573d86c5228c89cff332",
10+
"version": "4.4.3"
11+
}
12+
},
13+
{
14+
"package": "DiscordKit",
15+
"repositoryURL": "https://github.com/SwiftcordApp/DiscordKit",
16+
"state": {
17+
"branch": "main",
18+
"revision": "f38c9228615275bb20051a0a7bff356e97f45620",
19+
"version": null
20+
}
21+
},
22+
{
23+
"package": "Lottie",
24+
"repositoryURL": "https://github.com/airbnb/lottie-ios.git",
25+
"state": {
26+
"branch": null,
27+
"revision": "4a6058cbbdfe4f74aeae92c8bd51ad3b0de2a1ee",
28+
"version": "3.3.0"
29+
}
30+
},
31+
{
32+
"package": "PLCrashReporter",
33+
"repositoryURL": "https://github.com/microsoft/PLCrashReporter.git",
34+
"state": {
35+
"branch": null,
36+
"revision": "81cdec2b3827feb03286cb297f4c501a8eb98df1",
37+
"version": "1.10.2"
38+
}
39+
},
40+
{
41+
"package": "Reachability",
42+
"repositoryURL": "https://github.com/ashleymills/Reachability.swift",
43+
"state": {
44+
"branch": null,
45+
"revision": "c01bbdf2d633cf049ae1ed1a68a2020a8bda32e2",
46+
"version": "5.1.0"
47+
}
48+
},
49+
{
50+
"package": "Sparkle",
51+
"repositoryURL": "https://github.com/sparkle-project/Sparkle",
52+
"state": {
53+
"branch": null,
54+
"revision": "286edd1fa22505a9e54d170e9fd07d775ea233f2",
55+
"version": "2.1.0"
56+
}
57+
},
58+
{
59+
"package": "swiftui-cached-async-image",
60+
"repositoryURL": "https://github.com/lorenzofiamingo/swiftui-cached-async-image",
61+
"state": {
62+
"branch": null,
63+
"revision": "467a3d17479887943ab917a379e62bbaff60ac8a",
64+
"version": "2.1.1"
65+
}
1066
}
11-
},
12-
{
13-
"identity" : "discordkit",
14-
"kind" : "remoteSourceControl",
15-
"location" : "https://github.com/SwiftcordApp/DiscordKit",
16-
"state" : {
17-
"branch" : "main",
18-
"revision" : "f38c9228615275bb20051a0a7bff356e97f45620"
19-
}
20-
},
21-
{
22-
"identity" : "lottie-ios",
23-
"kind" : "remoteSourceControl",
24-
"location" : "https://github.com/airbnb/lottie-ios.git",
25-
"state" : {
26-
"revision" : "4a6058cbbdfe4f74aeae92c8bd51ad3b0de2a1ee",
27-
"version" : "3.3.0"
28-
}
29-
},
30-
{
31-
"identity" : "plcrashreporter",
32-
"kind" : "remoteSourceControl",
33-
"location" : "https://github.com/microsoft/PLCrashReporter.git",
34-
"state" : {
35-
"revision" : "81cdec2b3827feb03286cb297f4c501a8eb98df1",
36-
"version" : "1.10.2"
37-
}
38-
},
39-
{
40-
"identity" : "reachability.swift",
41-
"kind" : "remoteSourceControl",
42-
"location" : "https://github.com/ashleymills/Reachability.swift",
43-
"state" : {
44-
"revision" : "c01bbdf2d633cf049ae1ed1a68a2020a8bda32e2",
45-
"version" : "5.1.0"
46-
}
47-
},
48-
{
49-
"identity" : "sparkle",
50-
"kind" : "remoteSourceControl",
51-
"location" : "https://github.com/sparkle-project/Sparkle",
52-
"state" : {
53-
"revision" : "286edd1fa22505a9e54d170e9fd07d775ea233f2",
54-
"version" : "2.1.0"
55-
}
56-
},
57-
{
58-
"identity" : "swiftui-cached-async-image",
59-
"kind" : "remoteSourceControl",
60-
"location" : "https://github.com/lorenzofiamingo/swiftui-cached-async-image",
61-
"state" : {
62-
"revision" : "467a3d17479887943ab917a379e62bbaff60ac8a",
63-
"version" : "2.1.1"
64-
}
65-
},
66-
{
67-
"identity" : "swiftygif",
68-
"kind" : "remoteSourceControl",
69-
"location" : "https://github.com/cryptoAlgorithm/SwiftyGif",
70-
"state" : {
71-
"branch" : "master",
72-
"revision" : "4c271659307fc780728b3448419bc67678756cb0"
73-
}
74-
}
75-
],
76-
"version" : 2
67+
]
68+
},
69+
"version": 1
7770
}

0 commit comments

Comments
 (0)