Skip to content

Conversation

@N-Dekker
Copy link
Member

@N-Dekker N-Dekker commented Jun 23, 2023

This pull request is basically complementary to improvements in itk::ElastixRegistrationMethod:

It allows itk::TransformixFilter to read back the transform parameter files written by itk::ElastixRegistrationMethod (as well as those written by the elastix executable)

@N-Dekker N-Dekker requested review from mstaring and stefanklein June 23, 2023 18:31
@N-Dekker N-Dekker merged commit 4accfb3 into main Jun 26, 2023
@N-Dekker N-Dekker deleted the TransformixFilter-TransformParameterFileName branch June 26, 2023 11:58
@N-Dekker
Copy link
Member Author

N-Dekker commented Jun 27, 2023

@N-Dekker TODO Document the effect of calling both SetTransformParameterFileName and SetTransformParameterObject on the same TransformixFilter instance. Discussed with Marius (@mstaring): the current effect is correct: one call "overrules" the other.

@mstaring Should a subsequent SetTransformParameterObject call then erase the TransformParameterFileName property?

N-Dekker added a commit to N-Dekker/ITKElastix that referenced this pull request Jul 19, 2023
Follow-up to InsightSoftwareConsortium#211
commit 1043f10 "ENH: Bump elastix version to
2023-05-15, use C++17"

Including:

  SuperElastix/elastix#936
  SuperElastix/elastix@115d8e1
  ENH: Add `ElastixRegistrationMethod::SetInitialTransform

  SuperElastix/elastix#933
  SuperElastix/elastix@d33a0d5
  BUG: Fix reference count in ConvertItkTransformBaseToSingleItkTransform

  SuperElastix/elastix#924
  SuperElastix/elastix@71a4a9a
  ENH: Add TransformParameterFileName property to TransformixFilter

  SuperElastix/elastix#922
  SuperElastix/elastix@9d76b86
  ENH: Restore ELASTIX_BUILD_EXECUTABLE CMake option

  SuperElastix/elastix#909
  SuperElastix/elastix@9e64269
  ENH: ElastixRegistrationMethod writes initial transform parameter files

  SuperElastix/elastix#903
  SuperElastix/elastix@2170592
  ENH: Remove the letter 's' from "InitialTransformParametersFileName"

  SuperElastix/elastix#898
  SuperElastix/elastix@691c358
  BUG: Add InitialTransformParameterObject maps to registration result
N-Dekker added a commit to N-Dekker/ITKElastix that referenced this pull request Jul 20, 2023
Follow-up to InsightSoftwareConsortium#211
commit 1043f10 "ENH: Bump elastix version to
2023-05-15, use C++17"

Including:

  SuperElastix/elastix#936
  SuperElastix/elastix@115d8e1
  ENH: Add `ElastixRegistrationMethod::SetInitialTransform

  SuperElastix/elastix#933
  SuperElastix/elastix@d33a0d5
  BUG: Fix reference count in ConvertItkTransformBaseToSingleItkTransform

  SuperElastix/elastix#924
  SuperElastix/elastix@71a4a9a
  ENH: Add TransformParameterFileName property to TransformixFilter

  SuperElastix/elastix#922
  SuperElastix/elastix@9d76b86
  ENH: Restore ELASTIX_BUILD_EXECUTABLE CMake option

  SuperElastix/elastix#909
  SuperElastix/elastix@9e64269
  ENH: ElastixRegistrationMethod writes initial transform parameter files

  SuperElastix/elastix#903
  SuperElastix/elastix@2170592
  ENH: Remove the letter 's' from "InitialTransformParametersFileName"

  SuperElastix/elastix#898
  SuperElastix/elastix@691c358
  BUG: Add InitialTransformParameterObject maps to registration result
N-Dekker added a commit to N-Dekker/ITKElastix that referenced this pull request Jul 25, 2023
Follow-up to InsightSoftwareConsortium#211
commit 1043f10 "ENH: Bump elastix version to
2023-05-15, use C++17"

Including:

  SuperElastix/elastix#936
  SuperElastix/elastix@115d8e1
  ENH: Add `ElastixRegistrationMethod::SetInitialTransform

  SuperElastix/elastix#933
  SuperElastix/elastix@d33a0d5
  BUG: Fix reference count in ConvertItkTransformBaseToSingleItkTransform

  SuperElastix/elastix#924
  SuperElastix/elastix@71a4a9a
  ENH: Add TransformParameterFileName property to TransformixFilter

  SuperElastix/elastix#922
  SuperElastix/elastix@9d76b86
  ENH: Restore ELASTIX_BUILD_EXECUTABLE CMake option

  SuperElastix/elastix#909
  SuperElastix/elastix@9e64269
  ENH: ElastixRegistrationMethod writes initial transform parameter files

  SuperElastix/elastix#903
  SuperElastix/elastix@2170592
  ENH: Remove the letter 's' from "InitialTransformParametersFileName"

  SuperElastix/elastix#898
  SuperElastix/elastix@691c358
  BUG: Add InitialTransformParameterObject maps to registration result
N-Dekker added a commit to InsightSoftwareConsortium/ITKElastix that referenced this pull request Jul 25, 2023
Follow-up to #211
commit 1043f10 "ENH: Bump elastix version to
2023-05-15, use C++17"

Including:

  SuperElastix/elastix#936
  SuperElastix/elastix@115d8e1
  ENH: Add `ElastixRegistrationMethod::SetInitialTransform

  SuperElastix/elastix#933
  SuperElastix/elastix@d33a0d5
  BUG: Fix reference count in ConvertItkTransformBaseToSingleItkTransform

  SuperElastix/elastix#924
  SuperElastix/elastix@71a4a9a
  ENH: Add TransformParameterFileName property to TransformixFilter

  SuperElastix/elastix#922
  SuperElastix/elastix@9d76b86
  ENH: Restore ELASTIX_BUILD_EXECUTABLE CMake option

  SuperElastix/elastix#909
  SuperElastix/elastix@9e64269
  ENH: ElastixRegistrationMethod writes initial transform parameter files

  SuperElastix/elastix#903
  SuperElastix/elastix@2170592
  ENH: Remove the letter 's' from "InitialTransformParametersFileName"

  SuperElastix/elastix#898
  SuperElastix/elastix@691c358
  BUG: Add InitialTransformParameterObject maps to registration result
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants