Remove the letter 's' from "InitialTransformParametersFileName" #903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N-Dekker
force-pushed
the
Replace-InitialTransformParametersFileName-with-InitialTransformParameterFileName
branch
from
0685a7f to
3f62e6a
Compare
Member
Author
|
Discussed at the sprint today, we agreed to have it merged. But carefully! |
By default, started using "InitialTransformParameterFileName" (without 's'), instead of "InitialTransformParametersFileName" (with 's'), as parameter name. This commit still supports reading and retrieving the old parameter name, but only for backward compatibility (producing a warning). Aims to improve consistency. The elastix manual uses the term "parameter file" (and not "parameters file"), and `itk::ElastixRegistrationMethod` has `GetInitialTransformParameterFileName` and `SetInitialTransformParameterFileName` member functions (without 's' in their name). Addresses issue #900, "InitialTransformParametersFileName or InitialTransformParameterFileName? (with or without letter 's')"
Replaced "InitialTransformParametersFileName" with "InitialTransformParameterFileName" (which is now preferable).
Replaced "InitialTransformParametersFileName" with "InitialTransformParameterFileName" (which is now preferable).
Replaced "InitialTransformParametersFileName" with "InitialTransformParameterFileName" (which is now preferable). Still supported the old spelling (with letter 's') as input.
N-Dekker
force-pushed
the
Replace-InitialTransformParametersFileName-with-InitialTransformParameterFileName
branch
from
3f62e6a to
d9f5042
Compare
N-Dekker
deleted the
Replace-InitialTransformParametersFileName-with-InitialTransformParameterFileName
branch
N-Dekker
added a commit
to SuperElastix/manual
that referenced
this pull request
Jun 6, 2023
Follow-up to pull request SuperElastix/elastix#903 commit SuperElastix/elastix@2170592 Addresses issue SuperElastix/elastix#900, "InitialTransformParametersFileName or InitialTransformParameterFileName? (with or without letter 's')"
N-Dekker
added a commit
to SuperElastix/manual
that referenced
this pull request
Jun 6, 2023
Follow-up to pull request SuperElastix/elastix#903 commit SuperElastix/elastix@2170592 Addresses issue SuperElastix/elastix#900, "InitialTransformParametersFileName or InitialTransformParameterFileName? (with or without letter 's')"
N-Dekker
added a commit
to N-Dekker/ITKElastix
that referenced
this pull request
Jul 19, 2023
Follow-up to InsightSoftwareConsortium#211 commit 1043f10 "ENH: Bump elastix version to 2023-05-15, use C++17" Including: SuperElastix/elastix#936 SuperElastix/elastix@115d8e1 ENH: Add `ElastixRegistrationMethod::SetInitialTransform SuperElastix/elastix#933 SuperElastix/elastix@d33a0d5 BUG: Fix reference count in ConvertItkTransformBaseToSingleItkTransform SuperElastix/elastix#924 SuperElastix/elastix@71a4a9a ENH: Add TransformParameterFileName property to TransformixFilter SuperElastix/elastix#922 SuperElastix/elastix@9d76b86 ENH: Restore ELASTIX_BUILD_EXECUTABLE CMake option SuperElastix/elastix#909 SuperElastix/elastix@9e64269 ENH: ElastixRegistrationMethod writes initial transform parameter files SuperElastix/elastix#903 SuperElastix/elastix@2170592 ENH: Remove the letter 's' from "InitialTransformParametersFileName" SuperElastix/elastix#898 SuperElastix/elastix@691c358 BUG: Add InitialTransformParameterObject maps to registration result
N-Dekker
added a commit
to N-Dekker/ITKElastix
that referenced
this pull request
Jul 20, 2023
Follow-up to InsightSoftwareConsortium#211 commit 1043f10 "ENH: Bump elastix version to 2023-05-15, use C++17" Including: SuperElastix/elastix#936 SuperElastix/elastix@115d8e1 ENH: Add `ElastixRegistrationMethod::SetInitialTransform SuperElastix/elastix#933 SuperElastix/elastix@d33a0d5 BUG: Fix reference count in ConvertItkTransformBaseToSingleItkTransform SuperElastix/elastix#924 SuperElastix/elastix@71a4a9a ENH: Add TransformParameterFileName property to TransformixFilter SuperElastix/elastix#922 SuperElastix/elastix@9d76b86 ENH: Restore ELASTIX_BUILD_EXECUTABLE CMake option SuperElastix/elastix#909 SuperElastix/elastix@9e64269 ENH: ElastixRegistrationMethod writes initial transform parameter files SuperElastix/elastix#903 SuperElastix/elastix@2170592 ENH: Remove the letter 's' from "InitialTransformParametersFileName" SuperElastix/elastix#898 SuperElastix/elastix@691c358 BUG: Add InitialTransformParameterObject maps to registration result
N-Dekker
added a commit
to N-Dekker/ITKElastix
that referenced
this pull request
Jul 25, 2023
Follow-up to InsightSoftwareConsortium#211 commit 1043f10 "ENH: Bump elastix version to 2023-05-15, use C++17" Including: SuperElastix/elastix#936 SuperElastix/elastix@115d8e1 ENH: Add `ElastixRegistrationMethod::SetInitialTransform SuperElastix/elastix#933 SuperElastix/elastix@d33a0d5 BUG: Fix reference count in ConvertItkTransformBaseToSingleItkTransform SuperElastix/elastix#924 SuperElastix/elastix@71a4a9a ENH: Add TransformParameterFileName property to TransformixFilter SuperElastix/elastix#922 SuperElastix/elastix@9d76b86 ENH: Restore ELASTIX_BUILD_EXECUTABLE CMake option SuperElastix/elastix#909 SuperElastix/elastix@9e64269 ENH: ElastixRegistrationMethod writes initial transform parameter files SuperElastix/elastix#903 SuperElastix/elastix@2170592 ENH: Remove the letter 's' from "InitialTransformParametersFileName" SuperElastix/elastix#898 SuperElastix/elastix@691c358 BUG: Add InitialTransformParameterObject maps to registration result
N-Dekker
added a commit
to InsightSoftwareConsortium/ITKElastix
that referenced
this pull request
Jul 25, 2023
Follow-up to #211 commit 1043f10 "ENH: Bump elastix version to 2023-05-15, use C++17" Including: SuperElastix/elastix#936 SuperElastix/elastix@115d8e1 ENH: Add `ElastixRegistrationMethod::SetInitialTransform SuperElastix/elastix#933 SuperElastix/elastix@d33a0d5 BUG: Fix reference count in ConvertItkTransformBaseToSingleItkTransform SuperElastix/elastix#924 SuperElastix/elastix@71a4a9a ENH: Add TransformParameterFileName property to TransformixFilter SuperElastix/elastix#922 SuperElastix/elastix@9d76b86 ENH: Restore ELASTIX_BUILD_EXECUTABLE CMake option SuperElastix/elastix#909 SuperElastix/elastix@9e64269 ENH: ElastixRegistrationMethod writes initial transform parameter files SuperElastix/elastix#903 SuperElastix/elastix@2170592 ENH: Remove the letter 's' from "InitialTransformParametersFileName" SuperElastix/elastix#898 SuperElastix/elastix@691c358 BUG: Add InitialTransformParameterObject maps to registration result
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, started using "InitialTransformParameterFileName" (without 's'), instead of "InitialTransformParametersFileName" (with 's'), as parameter name.
This commit still supports reading and retrieving the old parameter name, but only for backward compatibility (producing a warning).
Aims to improve consistency. The elastix manual uses the term "parameter file" (and not "parameters file"), and
itk::ElastixRegistrationMethodhasGetInitialTransformParameterFileNameandSetInitialTransformParameterFileNamemember functions (without 's' in their name).Addresses issue #900, "InitialTransformParametersFileName or InitialTransformParameterFileName? (with or without letter 's')"