Coordinated Spawns (Purple Edition) #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Metious
requested changes
Jan 15, 2024
There was a problem hiding this comment.
Testing this pull request, I'm now getting an NRE first that goes like the following:
[Error : Unity Log] NullReferenceException
Stack trace:
CellManager.RegisterCellEntity (LargeWorldEntity ent) (at <9ec6c1b62c324758b9c2d79021505be6>:0)
CellManager.RegisterEntity (LargeWorldEntity lwe) (at <9ec6c1b62c324758b9c2d79021505be6>:0)
Nautilus.MonoBehaviours.EntitySpawner+<>c__DisplayClass2_0.<SpawnAsync>b__0 () (at <c13f3a3dfa5c494f9fd922a160750b0b>:0)
UnityEngine.WaitUntil.get_keepWaiting () (at <bd0d47c27bd84106afaaecc2c74cdb94>:0)
UnityEngine.CustomYieldInstruction.MoveNext () (at <bd0d47c27bd84106afaaecc2c74cdb94>:0)
UnityEngine.SetupCoroutine.InvokeMoveNext (System.Collections.IEnumerator enumerator, System.IntPtr returnValueAddress) (at <bd0d47c27bd84106afaaecc2c74cdb94>:0)
Then I end up with my object infinitely spawning.
This PR is not done yet. I'm converting it to a draft to prevent accidental merges.
This reverts commit 7cd473a.
and hopefully fix the NRE that i still cannot replicate.
The issue was because the spawned objects was registered while being inactive in the scene.
MrPurple6411
commented
Jan 20, 2024
Metious
approved these changes
Jan 20, 2024
LeeTwentyThree
approved these changes
Jan 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made in this pull request