Refactor/move workspace logic to wrapper by SuZhou-Joe · Pull Request #9 · SuZhou-Joe/OpenSearch-Dashboards

SuZhou-Joe · 2024-02-23T02:49:03Z

Description

Issues Resolved

Screenshot

Testing the changes

Check List

All tests pass
- yarn test:jest
- yarn test:jest_integration
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

codecov-commenter · 2024-02-23T03:59:58Z

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 66.25%. Comparing base (dc240eb) to head (c7b0e81).

Files	Patch %	Lines
...ore/server/saved_objects/service/lib/repository.ts	60.00%	0 Missing and 2 partials ⚠️
...core/server/saved_objects/import/regenerate_ids.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           workspace       #9   +/-   ##
==========================================
  Coverage      66.24%   66.25%           
==========================================
  Files           3438     3438           
  Lines          66264    66240   -24     
  Branches       10694    10688    -6     
==========================================
- Hits           43899    43886   -13     
+ Misses         19677    19668    -9     
+ Partials        2688     2686    -2

Flag	Coverage Δ
Linux_1	`30.90% <14.28%> (+0.01%)`	⬆️
Linux_2	`55.41% <50.00%> (-0.01%)`	⬇️
Linux_3	`42.81% <0.00%> (+0.03%)`	⬆️
Linux_4	`34.55% <0.00%> (+0.02%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

…opensearch-project#253) (cherry picked from commit 734c890) Signed-off-by: Lin Wang <wonglam@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

…t#6105) * Import sample data to workspace Signed-off-by: Lin Wang <wonglam@amazon.com> * Enable workspace ui plugin Signed-off-by: Lin Wang <wonglam@amazon.com> * Add changelog for import sample data to current workspace Signed-off-by: Lin Wang <wonglam@amazon.com> * feat: register sample data as standalone app (#8) * feat: register sample data as standalone app Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add comment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: use props to pass homeLink Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Retrieve workspace id from request Signed-off-by: Lin Wang <wonglam@amazon.com> * Remove workspace id in query Signed-off-by: Lin Wang <wonglam@amazon.com> * Move changelog to fragments Signed-off-by: Lin Wang <wonglam@amazon.com> * Fix sample data list unit tests Signed-off-by: Lin Wang <wonglam@amazon.com> * Remove no need workspaces deps Signed-off-by: Lin Wang <wonglam@amazon.com> * Remove manual created changelogs Signed-off-by: Lin Wang <wonglam@amazon.com> * Changeset file for PR opensearch-project#6105 created/updated * Enable sample data in workspace overview page (#9) * enable sample data in workspace overview page Signed-off-by: Hailong Cui <ihailong@amazon.com> * add comments for empty id Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> * Add unit tests for getFinalSavedObjects in data sets util file Signed-off-by: Lin Wang <wonglam@amazon.com> * Add unit tests for renderImportSampleDataApp destroy Signed-off-by: Lin Wang <wonglam@amazon.com> * Address PR comments Signed-off-by: Lin Wang <wonglam@amazon.com> * Remove history listen in renderImportSampleDataApp Signed-off-by: Lin Wang <wonglam@amazon.com> * Remove Route for workspace import sample data entry point Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com> Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: Hailong Cui <ihailong@amazon.com> Co-authored-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Hailong Cui <ihailong@amazon.com>

…t#6105) (opensearch-project#6826) * Import sample data to workspace * Enable workspace ui plugin * Add changelog for import sample data to current workspace * feat: register sample data as standalone app (#8) * feat: register sample data as standalone app * feat: optimize code * feat: add comment * feat: use props to pass homeLink * feat: add unit test --------- * Retrieve workspace id from request * Remove workspace id in query * Move changelog to fragments * Fix sample data list unit tests * Remove no need workspaces deps * Remove manual created changelogs * Changeset file for PR opensearch-project#6105 created/updated * Enable sample data in workspace overview page (#9) * enable sample data in workspace overview page * add comments for empty id --------- * Add unit tests for getFinalSavedObjects in data sets util file * Add unit tests for renderImportSampleDataApp destroy * Address PR comments * Remove history listen in renderImportSampleDataApp * Remove Route for workspace import sample data entry point --------- (cherry picked from commit 3e9a159) Signed-off-by: Lin Wang <wonglam@amazon.com> Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Hailong Cui <ihailong@amazon.com>

SuZhou-Joe added 2 commits February 22, 2024 10:58

refact: move workspace specific logic to savedObjectWrapper

4060458

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: remove unnecessary changes

41204e2

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

github-actions bot added the first-time-contributor label Feb 23, 2024

SuZhou-Joe and others added 26 commits February 23, 2024 12:35

fix: unit test

888b77e

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

fix: some error

6560073

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

fix: some error

d1c3c23

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

fix: unit test error

c7b0e81

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: fix test error

8240051

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

refact: move workspace specific logic to savedObjectWrapper

e79bdd9

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

fix: some error

f21cfe5

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: fix test error

fedb974

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: remove useless config in test

f59df29

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: add CHANGELOG

19f1b8f

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: add more unit test

b4e97d5

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

fix: unit test

c8809f0

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: revert test in repository.test.js

d8e52fa

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: revert test in import_saved_objects.test.ts

6afe452

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: revert test in repository.test.js

0fd2229

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: add type

38071b3

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: optimize code and add comment

da391ce

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

fix: unit test error

406da0e

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

fix: integration test fail

ac0df5f

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: add missing code

1efb8ba

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: fix bootstrap error

225d64d

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: remove useless code

fd447ff

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: remove useless code

672b3ee

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: remove useless code

ddbeb58

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: merge

88ea904

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

SuZhou-Joe added 5 commits February 28, 2024 13:31

feat: optimize code

e59ab71

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

fix: unit test

cbcc035

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: remove useless code

200b204

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: optimize code

21a6b22

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: remove useless CHANGELOG

25c32e5

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor/move workspace logic to wrapper#9

Refactor/move workspace logic to wrapper#9
SuZhou-Joe wants to merge 33 commits intoworkspacefrom
refactor/move-workspace-logic-to-wrapper

SuZhou-Joe commented Feb 23, 2024

Uh oh!

codecov-commenter commented Feb 23, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

SuZhou-Joe commented Feb 23, 2024

Description

Issues Resolved

Screenshot

Testing the changes

Check List

Uh oh!

codecov-commenter commented Feb 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov-commenter commented Feb 23, 2024 •

edited

Loading