[Rename] elastic-eslint-config-kibana dependency#253
Merged
boktorbb merged 1 commit intoopensearch-project:mainfrom Apr 8, 2021
boktorbb:rename-eslint
Merged
[Rename] elastic-eslint-config-kibana dependency#253boktorbb merged 1 commit intoopensearch-project:mainfrom boktorbb:rename-eslint
boktorbb merged 1 commit intoopensearch-project:mainfrom
boktorbb:rename-eslint
Conversation
|
✅ DCO Check Passed e2d149a |
Renames elastic-eslint-config-kibana --> opensearch-eslint-config-opensearch-dashboards Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
|
✅ DCO Check Passed 9ac1004 |
kavilla
reviewed
Apr 7, 2021
Member
kavilla
left a comment
kavilla
left a comment
There was a problem hiding this comment.
had to update a few references of the old package name in .eslintrc.js, package.json, packages/opensearch-eslint-config-opensearch-dashboards/package.json before I get the linter to run. Maybe packages/osd-plugin-generator/template/.eslintrc.js.ejs might need to be updated as well.
Member
|
we are told to keep things mostly the same, so after cherry-picking all the commits, everything resolved so my comments can be resolved. |
kavilla
approved these changes
Apr 7, 2021
ananzh
approved these changes
Apr 8, 2021
boktorbb
added a commit
that referenced
this pull request
Apr 8, 2021
Renames elastic-eslint-config-kibana --> opensearch-eslint-config-opensearch-dashboards Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
SuZhou-Joe
pushed a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Feb 28, 2024
…opensearch-project#253) (cherry picked from commit 734c890) Signed-off-by: Lin Wang <wonglam@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Renames elastic-eslint-config-kibana --> opensearch-eslint-config-opensearch-dashboards
Issues Resolved
Check List