Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opa-react: fix typescript errors for vite matchers #75

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

srenatus
Copy link
Member

@srenatus srenatus commented Jul 4, 2024

Following the instructions shared here:
testing-library/jest-dom#439 (comment)

Copy link

changeset-bot bot commented Jul 4, 2024

⚠️ No Changeset found

Latest commit: 504f1de

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@srenatus srenatus force-pushed the sr/opa-react/ts-hurdles branch from 6df13cd to 7b7318b Compare July 5, 2024 07:20
Following the instructions shared here:
testing-library/jest-dom#439 (comment)

Signed-off-by: Stephan Renatus <[email protected]>
@srenatus srenatus force-pushed the sr/opa-react/ts-hurdles branch from 7b7318b to 504f1de Compare July 5, 2024 07:22
@srenatus srenatus changed the title opa-react: typescript woes opa-react: fix typescript errors for vite matchers Jul 5, 2024
@srenatus srenatus marked this pull request as ready for review July 5, 2024 07:22
@@ -4,6 +4,6 @@
"compilerOptions": {
"jsx": "react-jsx",
"allowSyntheticDefaultImports": true,
"types": ["@testing-library/jest-dom"]
"types": ["vitest/globals"]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this was the trick. 🤔

@srenatus srenatus merged commit 0f5f661 into main Jul 5, 2024
5 checks passed
@srenatus srenatus deleted the sr/opa-react/ts-hurdles branch July 5, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant