[JSZip v3] Blob, Promise and more. #275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The methods `.file(name, data)` and `.loadAsync(data)` now accept Blob and promises of supported types (string, Uint8Array, etc).
Now, users can override the `JSZip.external.Promise` object and use their own.
A zip file is designed to be read backward so a stream is not suited
for this task. We could read the whole stream in memory but that would
be very counter-intuitive. The previous message is too generic ("The
data of [...] is in an unsupported format") and a better message will
save hours of debugging.
JSHint wasn't configured correctly. This commit adds enforcing rules and apply them on production files, test files and documentation files. Also fix offending lines.
- es6-promise is kept in 3.0 until stefanpenner/es6-promise#177 is released - grunt-contrib-connect is kept in 1.0.0 until gruntjs/grunt-contrib-connect#213 is resolved
It almost worked, we just needed a concat fix.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds several things:
On features,
loadAsync()andfile()JSZip.externalasync("array")On
This should cover the remaining bullet points of #224.