Merged
Conversation
The function `isArray` is imported but not used. On IE 8, the method `Array.isArray` doesn't exist and we get an error.
dduponchel
added a commit
to dduponchel/jszip
that referenced
this pull request
Mar 31, 2016
- es6-promise is kept in 3.0 until stefanpenner/es6-promise#177 is released - grunt-contrib-connect is kept in 1.0.0 until gruntjs/grunt-contrib-connect#213 is resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function
isArrayis imported but not used. On IE 8, the methodArray.isArraydoesn't exist and we get an error.