Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR]: Set seed time / ratio for a specific tag #88

Closed
1 of 2 tasks
quorn23 opened this issue Jan 6, 2022 · 4 comments · Fixed by #323
Closed
1 of 2 tasks

[FR]: Set seed time / ratio for a specific tag #88

quorn23 opened this issue Jan 6, 2022 · 4 comments · Fixed by #323
Assignees
Labels
feature request New feature or request status:added-to-develop Feature Request or Bug Fix is in Develop

Comments

@quorn23
Copy link

quorn23 commented Jan 6, 2022

Is your feature request related to a problem? Please elaborate.

No

Describe the solution you'd like

would it be possible to add the possibility to set a seed-time via qbit-manage for a specific tag? So i could just set the seeding time for "cross-seed" tagged torrents to 6 days for example?

TABLE — Today at 11:21 PM
Something like that would probably suit my issue the other day regarding having a long term seeding tag thats > ignored/permaseed also
Say I want to set a tracker specific seed time/ratio rule, but also have an lts (long term seeding) category I use that I just want > to exclude from automatic pausing so it can remain seeding perpetually even if the torrent is from that tracker.

As far as I can see from the config and some brief digging around github this isnt supported at the tracker tag level and I > would instead need to forego per tracker limits and just set those limits the same across all trackers per category under the > nohardlinks section? So that the lts category isnt being controlled by qbm?

These are two examples for the FR. Having the possibility to define those for tags we can specify in qbit-manage would help some use cases.

Does your solution involve any of the following?

  • New config option
  • New command option

Describe alternatives you've considered

Tried to set a tracker tag as "cross-seed" for my case as discussed in Discord. Didn't do the trick

Who will this benefit?

Everyone that has the need to handle specific tags with specific times/ratios

Additional Information

No response

@bobokun
Copy link
Collaborator

bobokun commented Mar 8, 2022

I'm thinking of implementing a priority feature for specifying share limits. Please take a look at the sample config to see if it would satisfy this requirements. This would mean that you will no longer be able to specify the share limits in the tracker or nohardlinks section of the config.yml and that would be deprecated and replaced with the following below, but that won't be an issue since anything you can do in the current config under those two sections would be able to be done in the new share_limits section.

share_limits:
  noHL:
    priority: 1
    tags:
    - noHL
    exclude_tags:
    - Beyond-HD
    categories:
    - RadarrComplete
    - SonarrComplete
    max_ratio: 4.0
    max_seeding_time: 129600
    limit_upload_speed:
  cross-seed:
    priority: 2
    tags:
    - cross-seed
    max_ratio: 1.0
    max_seeding_time: 10200
  grouping3:
    priority: 3
    tags:
    - PassThePopcorn
    - blutopia
    max_ratio: 2.0
    max_seeding_time: 130000

How this works is that when tagging new torrents, or tagging noHL/cross-seed, it will start from the first priority and if it matches any of the tags it will apply the share limits defined. If not it will move onto the next priority etc...

Note: This is not yet implemented, I'm still brainstorming ideas on what would be the best way to implement this

@quorn23
Copy link
Author

quorn23 commented Mar 18, 2022

Looking at this, i think this would work for such use-cases and gives a nice additional flexibility.

bobokun added a commit that referenced this issue May 31, 2023
…tegories specified per group

(Closes #88, Closes #306, Closes #259, Closes #308, Closes #137)
@bobokun
Copy link
Collaborator

bobokun commented May 31, 2023

Hi, I just pushed out this new feature that needs some thorough testing!

Please refer to the new configuration.yml.sample on how to get setup.
Here's a diff of the new changes for your reference:
https://github.com/StuffAnThings/qbit_manage/compare/develop#diff-e5794b6d2186004aa3ee69cd4dee7bbd48d8e0edd9f1da90d03393ec28cbf912

New Features

  • Adds new command share_limits, --share-limits , QBT_SHARE_LIMITS=True to update share limits based on tags/categories specified per group

Validation Suggestion

  • This makes drastic changes to your share_limits so I HIGHLY suggest running with dry_run option multiple times to make sure it's correctly applying your share limits.
  • Turn off webhooks/notifications while testing
  • If you feel comfortable with the results of the dry run, consider running with cleanup: false first so it just updates the share limits without wiping away any torrents.

Breaking Changes

  • tag_nohardlinks only updates/removes noHL tag. It does not modify or cleanup share_limits anymore.
  • tag_update only adds tracker tags to torrent. It does not modify or cleanup share_limits anymore.
  • Please remove any references to share_limits from your configuration in the tracker/nohardlinks section

@bobokun bobokun added the status:added-to-develop Feature Request or Bug Fix is in Develop label May 31, 2023
@bobokun
Copy link
Collaborator

bobokun commented May 31, 2023

Not sure how many are following but I've decided to change. Please refer to the configuration.yml.sample for the update.
tags -> include_all_tags and include_any_tags
exclude_tags -> exclude_all_tags and exclude_any_tags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request status:added-to-develop Feature Request or Bug Fix is in Develop
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants