Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Expand and de-clutter menus for matching search results in homepage #2264 #2277

Conversation

omar-ahmed42
Copy link
Contributor

Description

  • Fix a bug where menus (accordions/feature groups) did not automatically expand on the homepage when search results matched.
  • De-clutter search results by hiding empty menus.

UI Change:

  • Image:

image

  • GIF:

fix-search-bar-homepage-menu-collapse

Closes #2264

Checklist

  • I have read the Contribution Guidelines
  • I have performed a self-review of my own code
  • I have attached images of the change if it is UI based
  • I have commented my code, particularly in hard-to-understand areas
  • If my code has heavily changed functionality I have updated relevant docs on Stirling-PDFs doc repo
  • My changes generate no new warnings
  • I have read the section Add New Translation Tags (for new translation tags only)

- Hide empty menus (accordions/feature groups) that don't match search criteria.
- Fix a bug where menus (accordions/feature groups) did not automatically expand on the homepage when search results matched.
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 20, 2024
@github-actions github-actions bot added the Front End Issues or pull requests related to front-end development label Nov 20, 2024
@dosubot dosubot bot added the Bug Something isn't working label Nov 20, 2024
@Frooodle Frooodle enabled auto-merge (squash) November 20, 2024 17:29
@Frooodle Frooodle disabled auto-merge November 21, 2024 14:24
@Frooodle Frooodle merged commit aeca2b2 into Stirling-Tools:main Nov 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Front End Issues or pull requests related to front-end development size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Search bar on homepage doesn't work with collapsible menus
2 participants