Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions charts/stirling-pdf/Chart.yaml
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should increment the chart version

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree it needs to be updated but you want me to set the new version?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking to @Frooodle for guidance, preferably a major version increment (3.y.z ?)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes agreed please do major chart bump here
I'll then merge

Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
apiVersion: v2
appVersion: 1.3.2
appVersion: 2.1.5
description: locally hosted web application that allows you to perform various operations on PDF files
home: https://github.com/Stirling-Tools/Stirling-PDF
keywords:
Expand All @@ -12,4 +12,4 @@ maintainers:
name: stirling-pdf-chart
sources:
- https://github.com/Stirling-Tools/Stirling-PDF-chart
version: 2.2.0
version: 3.0.0
2 changes: 1 addition & 1 deletion charts/stirling-pdf/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# stirling-pdf-chart

![Version: 2.2.0](https://img.shields.io/badge/Version-2.2.0-informational?style=flat-square) ![AppVersion: 1.3.2](https://img.shields.io/badge/AppVersion-1.3.2-informational?style=flat-square)
![Version: 3.0.0](https://img.shields.io/badge/Version-3.0.0-informational?style=flat-square) ![AppVersion: 2.1.5](https://img.shields.io/badge/AppVersion-2.1.5-informational?style=flat-square)

locally hosted web application that allows you to perform various operations on PDF files

Expand Down
4 changes: 2 additions & 2 deletions charts/stirling-pdf/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -87,15 +87,15 @@ spec:
{{- if .Values.probes.liveness.enabled }}
livenessProbe:
httpGet:
path: {{ .Values.rootPath}}
path: {{ .Values.rootPath}}api/v1/info/status
port: http
{{ toYaml .Values.probes.livenessHttpGetConfig | indent 12 }}
{{ toYaml (omit .Values.probes.liveness "enabled") | indent 10 }}
{{- end }}
{{- if .Values.probes.readiness.enabled }}
readinessProbe:
httpGet:
path: {{ .Values.rootPath}}
path: {{ .Values.rootPath}}api/v1/info/status
port: http
{{ toYaml .Values.probes.readinessHttpGetConfig | indent 12 }}
{{ toYaml (omit .Values.probes.readiness "enabled") | indent 10 }}
Expand Down
22 changes: 16 additions & 6 deletions charts/stirling-pdf/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,16 +22,26 @@ rootPath: /

# -- Environment variables to add to the stirling-pdf pods
envs: []
# - name: UI_APP_NAME
# - name: UI_APPNAME
# value: "Stirling PDF"
# - name: UI_HOME_DESCRIPTION
# - name: UI_HOMEDESCRIPTION
# value: "Your locally hosted one-stop-shop for all your PDF needs."
# - name: UI_APP_NAVBAR_NAME
# - name: UI_APPNAMENAVBAR
# value: "Stirling PDF"
# - name: ALLOW_GOOGLE_VISIBILITY
# value: "true"
# - name: APP_LOCALE
# - name: LANGS
# value: "en_GB"
# - name: SYSTEM_DEFAULTLOCALE
# value: "en-GB"
# - name: SECURITY_ENABLELOGIN
# value: "false"
# - name: DISABLE_ADDITIONAL_FEATURES
# value: "false"
# - name: FAT_DOCKER
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this just a build option?
I cannot find any documentation indicating what this is used for.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# value: "true"
# - name: SYSTEM_MAXFILESIZE
# value: "500"
# - name: SYSTEM_GOOGLEVISIBILITY
# value: "true"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add some other env vars, especially the new ones from v2.0?
Sourced these from https://docs.stirlingpdf.com/Configuration
Excluding oauth/saml since its provider-centric

Suggested change
# value: "true"
# value: "true"
# - name: UI_LOGOSTYLE
# value: "modern"
# - name: SYSTEM_SHOWUPDATE
# value: "false"
# - name: SYSTEM_SHOWUPDATEONLYADMIN
# value: "false"
# - name: ENDPOINTS_GROUPSTOREMOVE
# value: ""
# - name: JAVA_CUSTOM_OPTS
# value: ""
# - name: MODE
# value: "BOTH"
# # When MODE = FRONTEND
# - name: VITE_API_BASE_URL
# value: "http://backend:8080"
# - name: SYSTEM_FRONTENDURL
# value: "https://pdf.example.com"
# - name: SYSTEM_CORSALLOWEDORIGINS
# value: "https://pdf.example.com,https://pdf-staging.example.com"
# # Authentication
# - name: SECURITY_ENABLELOGIN
# value: "true"
# - name: SECURITY_LOGINMETHOD
# value: "all"
# - name: SECURITY_INITIALLOGIN_USERNAME
# value: "admin"
# - name: SECURITY_INITIALLOGIN_PASSWORD
# value: "stirling"
# - name: SECURITY_JWT_PERSISTENCE
# value: "true"
# - name: SECURITY_JWT_ENABLEKEYROTATION
# value: "true"
# - name: SECURITY_JWT_ENABLEKEYCLEANUP
# value: "true"
# - name: SECURITY_JWT_KEYRETENTIONDAYS
# value: "7"
# # E-mail invites
# - name: MAIL_ENABLED
# value: "false"
# - name: MAIL_FROM
# value: "noreply@example.com"
# - name: MAIL_ENABLEINVITES
# value: "false"
# - name: MAIL_HOST
# value: "smtp.gmail.com"
# - name: MAIL_PORT
# value: "587"
# - name: MAIL_USERNAME
# value: "your-email@gmail.com"
# - name: MAIL_PASSWORD
# value: "your-app-password"
# - name: MAIL_TLS_ENABLED
# value: "true"
# # When relying on Stirling-PDF to terminate TLS
# - name: SYSTEM_SERVERCERTIFICATE_ENABLED
# value: "true"
# - name: SYSTEM_SERVERCERTIFICATE_ORGANIZATIONNAME
# value: "My Company"
# - name: SYSTEM_SERVERCERTIFICATE_VALIDITY
# value: "365"
# - name: SYSTEM_SERVERCERTIFICATE_REGENERATEONSTARTUP
# value: "false"
# - name: KEYSTORE_PASSWORD
# value: "password"
# # PDF trust sources
# - name: SECURITY_VALIDATION_TRUST_SERVERASANCHOR
# value: "true"
# - name: SECURITY_VALIDATION_TRUST_USESYSTEMTRUST
# value: "true"
# - name: SECURITY_VALIDATION_TRUST_USEMOZILLABUNDLE
# value: "true"
# - name: SECURITY_VALIDATION_TRUST_USEAATL
# value: "false"
# - name: SECURITY_VALIDATION_TRUST_USEEUTL
# value: "false"
# - name: SECURITY_VALIDATION_REVOCATION_MODE
# value: "ocsp+crl"
# - name: SECURITY_VALIDATION_REVOCATION_HARDFAIL
# value: "false"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to see them all
If you want to provide the vite url and the mode front-end and backend you 'need to be able to deploy one deployment for the front-end and another one for the backend
I think it's out of this pr scope


# -- Environment variables from secrets or configmaps to add to the stirling-pdf pods
envsFrom: []
Expand Down