Skip to content

Migrate to stirlingpdf v2.1.5#34

Merged
Frooodle merged 3 commits into
Stirling-Tools:mainfrom
serut:main
Jan 7, 2026
Merged

Migrate to stirlingpdf v2.1.5#34
Frooodle merged 3 commits into
Stirling-Tools:mainfrom
serut:main

Conversation

@serut
Copy link
Copy Markdown
Contributor

@serut serut commented Dec 24, 2025

In order to migrate to the latest version of your software, I had to change the probe that checks if the service is running well.

I've also updated virtual envs as their name changed between v1 and v2

It works well on my server.

Linked issue(s)

Fixes #33

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

@serut serut requested a review from Frooodle as a code owner December 24, 2025 12:27
@Frooodle
Copy link
Copy Markdown
Member

Seems our pre commits are not working don't think it's related to your change will check it out in 2 days (due to Christmas) and then get this merged

Updated AppVersion badge in README.md from 1.3.2 to 2.1.5.
@serut
Copy link
Copy Markdown
Contributor Author

serut commented Dec 26, 2025

I think the pre-commit asks me to update the README with the app version used

@serut
Copy link
Copy Markdown
Contributor Author

serut commented Dec 26, 2025

Another important thing is we need to set METRICS_ENABLED: "true" to open healthcheck endpoint

# value: "false"
# - name: DISABLE_ADDITIONAL_FEATURES
# value: "false"
# - name: FAT_DOCKER
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this just a build option?
I cannot find any documentation indicating what this is used for.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should increment the chart version

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree it needs to be updated but you want me to set the new version?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking to @Frooodle for guidance, preferably a major version increment (3.y.z ?)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes agreed please do major chart bump here
I'll then merge

# - name: SYSTEM_MAXFILESIZE
# value: "500"
# - name: SYSTEM_GOOGLEVISIBILITY
# value: "true"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add some other env vars, especially the new ones from v2.0?
Sourced these from https://docs.stirlingpdf.com/Configuration
Excluding oauth/saml since its provider-centric

Suggested change
# value: "true"
# value: "true"
# - name: UI_LOGOSTYLE
# value: "modern"
# - name: SYSTEM_SHOWUPDATE
# value: "false"
# - name: SYSTEM_SHOWUPDATEONLYADMIN
# value: "false"
# - name: ENDPOINTS_GROUPSTOREMOVE
# value: ""
# - name: JAVA_CUSTOM_OPTS
# value: ""
# - name: MODE
# value: "BOTH"
# # When MODE = FRONTEND
# - name: VITE_API_BASE_URL
# value: "http://backend:8080"
# - name: SYSTEM_FRONTENDURL
# value: "https://pdf.example.com"
# - name: SYSTEM_CORSALLOWEDORIGINS
# value: "https://pdf.example.com,https://pdf-staging.example.com"
# # Authentication
# - name: SECURITY_ENABLELOGIN
# value: "true"
# - name: SECURITY_LOGINMETHOD
# value: "all"
# - name: SECURITY_INITIALLOGIN_USERNAME
# value: "admin"
# - name: SECURITY_INITIALLOGIN_PASSWORD
# value: "stirling"
# - name: SECURITY_JWT_PERSISTENCE
# value: "true"
# - name: SECURITY_JWT_ENABLEKEYROTATION
# value: "true"
# - name: SECURITY_JWT_ENABLEKEYCLEANUP
# value: "true"
# - name: SECURITY_JWT_KEYRETENTIONDAYS
# value: "7"
# # E-mail invites
# - name: MAIL_ENABLED
# value: "false"
# - name: MAIL_FROM
# value: "noreply@example.com"
# - name: MAIL_ENABLEINVITES
# value: "false"
# - name: MAIL_HOST
# value: "smtp.gmail.com"
# - name: MAIL_PORT
# value: "587"
# - name: MAIL_USERNAME
# value: "your-email@gmail.com"
# - name: MAIL_PASSWORD
# value: "your-app-password"
# - name: MAIL_TLS_ENABLED
# value: "true"
# # When relying on Stirling-PDF to terminate TLS
# - name: SYSTEM_SERVERCERTIFICATE_ENABLED
# value: "true"
# - name: SYSTEM_SERVERCERTIFICATE_ORGANIZATIONNAME
# value: "My Company"
# - name: SYSTEM_SERVERCERTIFICATE_VALIDITY
# value: "365"
# - name: SYSTEM_SERVERCERTIFICATE_REGENERATEONSTARTUP
# value: "false"
# - name: KEYSTORE_PASSWORD
# value: "password"
# # PDF trust sources
# - name: SECURITY_VALIDATION_TRUST_SERVERASANCHOR
# value: "true"
# - name: SECURITY_VALIDATION_TRUST_USESYSTEMTRUST
# value: "true"
# - name: SECURITY_VALIDATION_TRUST_USEMOZILLABUNDLE
# value: "true"
# - name: SECURITY_VALIDATION_TRUST_USEAATL
# value: "false"
# - name: SECURITY_VALIDATION_TRUST_USEEUTL
# value: "false"
# - name: SECURITY_VALIDATION_REVOCATION_MODE
# value: "ocsp+crl"
# - name: SECURITY_VALIDATION_REVOCATION_HARDFAIL
# value: "false"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to see them all
If you want to provide the vite url and the mode front-end and backend you 'need to be able to deploy one deployment for the front-end and another one for the backend
I think it's out of this pr scope

@Frooodle Frooodle merged commit 17a4ded into Stirling-Tools:main Jan 7, 2026
1 check passed
renovate Bot added a commit to sdwilsh/ansible-playbooks that referenced this pull request Jan 7, 2026
renovate Bot added a commit to sdwilsh/ansible-playbooks that referenced this pull request Feb 2, 2026
renovate Bot added a commit to sdwilsh/ansible-playbooks that referenced this pull request Feb 19, 2026
renovate Bot added a commit to sdwilsh/ansible-playbooks that referenced this pull request Feb 21, 2026
renovate Bot added a commit to sdwilsh/ansible-playbooks that referenced this pull request Mar 21, 2026
renovate Bot added a commit to sdwilsh/ansible-playbooks that referenced this pull request Mar 21, 2026
renovate Bot added a commit to sdwilsh/ansible-playbooks that referenced this pull request Apr 11, 2026
renovate Bot added a commit to sdwilsh/ansible-playbooks that referenced this pull request Apr 16, 2026
renovate Bot added a commit to sdwilsh/ansible-playbooks that referenced this pull request Apr 20, 2026
renovate Bot added a commit to sdwilsh/ansible-playbooks that referenced this pull request Apr 28, 2026
renovate Bot added a commit to sdwilsh/ansible-playbooks that referenced this pull request Apr 30, 2026
renovate Bot added a commit to sdwilsh/ansible-playbooks that referenced this pull request May 18, 2026
renovate Bot added a commit to sdwilsh/ansible-playbooks that referenced this pull request May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade to 2.1.3

3 participants