Fix compilation errors for new RViz with Qt6#820
Merged
SteveMacenski merged 8 commits intoSteveMacenski:ros2from Nov 22, 2025
Merged
Fix compilation errors for new RViz with Qt6#820SteveMacenski merged 8 commits intoSteveMacenski:ros2from
SteveMacenski merged 8 commits intoSteveMacenski:ros2from
Conversation
SteveMacenski
approved these changes
Nov 22, 2025
Owner
|
Thanks so much! I just haven't gotten around to it this yet so I appreciate the help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic Info
Description
We have talked about the compiling errors here: Added parameter
check_min_dist_and_heading_precisely#808In
slam_toolbox_common.cpp:24:was working when I used native Rolling, but not in docker (I probably used the wrong image), but still, I changed it to:
All other changes are in the
CMakeLists.txt. I decided to break my native Rolling instead of finding a correct image (We all are lazy), and built the latestrvizfrom source. After that,Qt5_FOUNDerrors were gone. Other version mismatch errors appeared and I fixed them.To differentiate them from their looks, I use Fusion style theme for Qt6 apps, and another dark theme for Qt5 apps;
On the left, RViz on Rolling with Qt6, and on the right, RViz on Jazzy with Qt5:
Future work that may be required
I don't have time to test with a
rollingrobot, but it should work as well as how a robot onrollingversion works 🙃 OR maybe this change is not enough for Qt6 upgrade, but still, it is better than before. Now, at least, it compiles and I was able to add the SlamToolboxPlugin panel to RViz.Note
Since you squashed the changes from my previous PR (above), the commit history of this PR from my fork includes those commits. You are probably used to this but I wanted to include the explanation, just in case.