Skip to content

Conversation

@james-ward
Copy link
Contributor


Basic Info

Info Please fill out this column
Ticket(s) this addresses Closes #632
Primary OS tested on Ubuntu
Robotic platform tested on Launch to check subscriber counts/service advertisements

Description of contribution in a few bullet points

  • Added parameter to control whether or not to load the map saver functionality. Defaults to loading map saver - functionality unchanged in default case.

Description of documentation updates required from your changes

  • Parameter added to all launch configs except localization (don't think it makes sense in that context?)

Future work that may be required in bullet points

None

James Ward added 3 commits August 22, 2023 11:45
Map saver will subscribe to the map topic and force updates of the map
even when nothing else is subscribed.
This allows it to be turned off to save processing cycles.
@SteveMacenski SteveMacenski merged commit 51f5ddc into SteveMacenski:ros2 Aug 22, 2023
@SteveMacenski
Copy link
Owner

Thanks!

SteveMacenski pushed a commit that referenced this pull request Sep 25, 2023
* Add parameter to stop map saver from being initialised

Map saver will subscribe to the map topic and force updates of the map
even when nothing else is subscribed.
This allows it to be turned off to save processing cycles.

* Add details of use_map_saver parameter to README

* Add defaulted-true use_map_saver parameter to launch configs

---------

Co-authored-by: James Ward <[email protected]>
SteveMacenski pushed a commit that referenced this pull request Sep 25, 2023
* Add parameter to stop map saver from being initialised

Map saver will subscribe to the map topic and force updates of the map
even when nothing else is subscribed.
This allows it to be turned off to save processing cycles.

* Add details of use_map_saver parameter to README

* Add defaulted-true use_map_saver parameter to launch configs

---------

Co-authored-by: James Ward <[email protected]>
SteveMacenski added a commit that referenced this pull request Sep 25, 2023
* Optional map saver (#633)

* Add parameter to stop map saver from being initialised

Map saver will subscribe to the map topic and force updates of the map
even when nothing else is subscribed.
This allows it to be turned off to save processing cycles.

* Add details of use_map_saver parameter to README

* Add defaulted-true use_map_saver parameter to launch configs

---------

Co-authored-by: James Ward <[email protected]>

* adding namespace support for map saving (#613)

* fix mismatched service name in rviz plugin (#634)

* bumping to 2.6.6 for release

---------

Co-authored-by: James Ward <[email protected]>
Co-authored-by: James Ward <[email protected]>
Co-authored-by: gene.su <[email protected]>
SteveMacenski added a commit that referenced this pull request Sep 25, 2023
* Optional map saver (#633)

* Add parameter to stop map saver from being initialised

Map saver will subscribe to the map topic and force updates of the map
even when nothing else is subscribed.
This allows it to be turned off to save processing cycles.

* Add details of use_map_saver parameter to README

* Add defaulted-true use_map_saver parameter to launch configs

---------

Co-authored-by: James Ward <[email protected]>

* adding namespace support for map saving (#613)

* fix mismatched service name in rviz plugin (#634)

* bumping iron to 2.7.2 for release

---------

Co-authored-by: James Ward <[email protected]>
Co-authored-by: James Ward <[email protected]>
Co-authored-by: gene.su <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Raster map is updated and published even with no external subscribers

2 participants