Skip to content

Conversation

@malban
Copy link
Contributor

@malban malban commented Jul 11, 2022

Basic Info

Info Please fill out this column
Ticket(s) this addresses
Primary OS tested on Ubuntu 18.04
Robotic platform tested on gazebo simulation of small indoor robot with single plane lidar

Description of contribution in a few bullet points

See #510

  • Added service to base class to enable switching between localization and mapping modes

Example use case would be to explore an area while building up a map in map mode and then switch to localization mode to perform tasks within that area.

Description of documentation updates required from your changes

  • Added new service to the README documentation.

Future work that may be required in bullet points

@malban malban changed the title Add service to toggle in and out of localization mode. Add service to toggle in and out of localization mode. (ros2) Jul 11, 2022
@malban malban changed the title Add service to toggle in and out of localization mode. (ros2) Add service to toggle in and out of localization mode. (ros2 branch) Jul 11, 2022
@malban malban force-pushed the localization-toggle-ros2 branch from 283d752 to 4011ba2 Compare July 12, 2022 01:21
@malban
Copy link
Contributor Author

malban commented Jul 12, 2022

Rebased and updated to publish covariance from #511

@malban malban force-pushed the localization-toggle-ros2 branch from 4011ba2 to 9abd179 Compare July 18, 2022 02:27
Copy link
Owner

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM

@malban malban force-pushed the localization-toggle-ros2 branch from 9abd179 to 66eef1b Compare July 18, 2022 19:27
@SteveMacenski SteveMacenski merged commit 9ce1278 into SteveMacenski:ros2 Jul 19, 2022
SteveMacenski pushed a commit that referenced this pull request Aug 24, 2022
SteveMacenski added a commit that referenced this pull request Aug 24, 2022
* Publish pose with covariance in localization mode. (#511)

* Visualize localization nodes and edges with different colors in the pose graph marker message. (#513)

* Fix edge marker id to not conflict with the localization edge marker. (#515)

* Stop ceres problem from freeing loss function (#519)

* Add map_and_localization node that supports toggling between mapping and localization modes with a service. (#512)

* resolve API change from galactic (#524)

* Fix segfault after loading posegraph (#527)

* Assign mapper to closure_assistant after loading posgraph

* Fix linting

* Midigate spamming for 50Hz lidar (#526)

* Increase scan filter queue_size

* Add scan_queue_size as parameter

Co-authored-by: Marc Alban <marcalban@hatchbed.com>
Co-authored-by: john-maidbot <78750993+john-maidbot@users.noreply.github.com>
Co-authored-by: Samuel Lindgren <samuel@dynorobotics.se>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants