Skip to content

Conversation

@OrangeQi-CQ
Copy link

@OrangeQi-CQ OrangeQi-CQ commented Jun 11, 2025

增加了脏位和访问位的接口

@Mivik Mivik merged commit ce54692 into Starry-OS:main Jun 16, 2025
@AsakuraMizu
Copy link

@OrangeQi-CQ First of all, thanks for your contributions! I'm now looking to upstream this fork to the original repository. Would you be open to porting the this PR to https://github.com/arceos-org/page_table_multiarch? If you're unavailable, I'd be happy to help port it.

@OrangeQi-CQ
Copy link
Author

@AsakuraMizu Thanks for your message! I'm currently away for a visit and won't be able to work on code until July 3rd at the earliest. If the PR is urgent, feel free to merge it on my behalf.

Regarding the is_dirty and is_accessed functions: you're correct that they require a TLB flush before use. In my implementation, I handled this at the arceos layer by calling flush_tlb() before invoking page_table_multiarch::is_dirty(). Would you prefer to move this TLB flush logic into the page_table_multiarch library instead? I'm open to your suggestion on the best approach here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants