[Feature] Use mem_pool property to create shared mem_tracker across resource groups (backport #64112) #65391
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
See this PR
What I'm doing:
Adding a new class shared_mem_tracker_manager. This class manages
shared_mem_trackerand will return the same mem tracker for the samemem_pool.What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check:
Note
Introduce a shared MemTracker per
mem_pooland wire it intoWorkGroupcreation/initialization, adding a new tracker type, Thrift field, and tests.mem_pooltoWorkGroup(ctor, accessors) and accept parent mem tracker ininitto support shared pools.MemTrackerManagerto return a shared parentMemTrackerpermem_pool; integrate inWorkGroupManager::create_workgroup_unlocked.DEFAULT_MEM_POOLand handle default vs custom pools.MemTrackerType::RESOURCE_GROUP_SHARED_MEMORY_POOLand corresponding error message.GlobalEnv::query_pool_mem_tracker_shared().TWorkGroupwith optionalmem_pool.WorkGroupctor/init API.Written by Cursor Bugbot for commit 9f41d21. This will update automatically on new commits. Configure here.
This is an automatic backport of pull request #64112 done by [Mergify](https://mergify.com).