-
Notifications
You must be signed in to change notification settings - Fork 2.3k
[Feature] Use mem_pool property to create shared mem_tracker across resource groups #64112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
murphyatwork
merged 9 commits into
StarRocks:main
from
martinr0x:mbogusz/use-mem-pool-be
Nov 12, 2025
Merged
[Feature] Use mem_pool property to create shared mem_tracker across resource groups #64112
murphyatwork
merged 9 commits into
StarRocks:main
from
martinr0x:mbogusz/use-mem-pool-be
Nov 12, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37da6f2 to
041cab4
Compare
2d16a0b to
5679186
Compare
Contributor
|
@cursor review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Bugbot reviewed your changes and found no bugs!
5b0a846 to
5032012
Compare
ZiheLiu
reviewed
Nov 6, 2025
murphyatwork
reviewed
Nov 6, 2025
Contributor
|
@Mergifyio rebase |
Contributor
✅ Branch has been successfully rebased |
5032012 to
60b088f
Compare
Contributor
|
@cursor review |
Signed-off-by: m.bogusz <[email protected]>
Signed-off-by: m.bogusz <[email protected]>
Signed-off-by: m.bogusz <[email protected]>
Signed-off-by: m.bogusz <[email protected]>
murphyatwork
approved these changes
Nov 12, 2025
ZiheLiu
approved these changes
Nov 12, 2025
kangkaisen
approved these changes
Nov 12, 2025
trueeyu
approved these changes
Nov 12, 2025
Contributor
|
@Mergifyio backport branch-3.4 |
Contributor
|
@Mergifyio backport branch-3.5 |
Contributor
✅ Backports have been createdDetails
|
Contributor
✅ Backports have been createdDetails
|
23 tasks
23 tasks
martinr0x
added a commit
to martinr0x/starrocks
that referenced
this pull request
Nov 13, 2025
martinr0x
added a commit
to martinr0x/starrocks
that referenced
this pull request
Nov 14, 2025
martinr0x
added a commit
to martinr0x/starrocks
that referenced
this pull request
Nov 14, 2025
…esource groups (StarRocks#64112) Signed-off-by: m.bogusz <[email protected]>
chris-celerdata
pushed a commit
to chris-celerdata/starrocks
that referenced
this pull request
Nov 14, 2025
zhaohehuhu
pushed a commit
to zhaohehuhu/starrocks
that referenced
this pull request
Nov 19, 2025
23 tasks
23 tasks
23 tasks
24 tasks
Closed
23 tasks
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
See this PR
What I'm doing:
Adding a new class shared_mem_tracker_manager. This class manages
shared_mem_trackerand will return the same mem tracker for the samemem_pool.What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check:
Note
Introduce a shared MemTracker per
mem_pooland wire it intoWorkGroupcreation/initialization, adding a new tracker type, Thrift field, and tests.mem_pooltoWorkGroup(ctor, accessors) and accept parent mem tracker ininitto support shared pools.MemTrackerManagerto return a shared parentMemTrackerpermem_pool; integrate inWorkGroupManager::create_workgroup_unlocked.DEFAULT_MEM_POOLand handle default vs custom pools.MemTrackerType::RESOURCE_GROUP_SHARED_MEMORY_POOLand corresponding error message.GlobalEnv::query_pool_mem_tracker_shared().TWorkGroupwith optionalmem_pool.WorkGroupctor/init API.Written by Cursor Bugbot for commit 9f41d21. This will update automatically on new commits. Configure here.