[BugFix] support SqlToScalarOperatorTranslator visit lambda functions more than one times #19843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kangkaisen
previously approved these changes
Mar 21, 2023
Seaven
previously approved these changes
Mar 21, 2023
|
run ADMIT TEST |
|
run admit_test |
Signed-off-by: Zhuhe Fang <[email protected]>
Signed-off-by: Zhuhe Fang <[email protected]>
Signed-off-by: Zhuhe Fang <[email protected]>
auto-merge was automatically disabled
March 21, 2023 08:17
Head branch was pushed to by a user without write access
fzhedu
force-pushed
the
transformLambdaFunctionMore
branch
from
1c2cfdb
to
e662725
Compare
|
Kudos, SonarCloud Quality Gate passed! |
kangkaisen
approved these changes
Mar 21, 2023
Seaven
approved these changes
Mar 21, 2023
|
@Mergifyio backport branch-3.0 |
|
@Mergifyio backport branch-2.5 |
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Mar 21, 2023
… more than one times (#19843) --------- Signed-off-by: Zhuhe Fang <[email protected]> (cherry picked from commit 863c40c) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/sql/ast/LambdaFunctionExpr.java
mergify bot
pushed a commit
that referenced
this pull request
Mar 21, 2023
… more than one times (#19843) --------- Signed-off-by: Zhuhe Fang <[email protected]> (cherry picked from commit 863c40c) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/sql/ast/LambdaFunctionExpr.java
fzhedu
added a commit
to fzhedu/starrocks
that referenced
this pull request
Mar 21, 2023
… more than one times (StarRocks#19843) --------- Signed-off-by: Zhuhe Fang <[email protected]>
fzhedu
added a commit
to fzhedu/starrocks
that referenced
this pull request
Mar 21, 2023
… more than one times (StarRocks#19843) --------- Signed-off-by: Zhuhe Fang <[email protected]>
fzhedu
added a commit
to fzhedu/starrocks
that referenced
this pull request
Mar 22, 2023
… more than one times (StarRocks#19843) --------- Signed-off-by: Zhuhe Fang <[email protected]>
fzhedu
added a commit
to fzhedu/starrocks
that referenced
this pull request
Mar 22, 2023
… more than one times (StarRocks#19843) --------- Signed-off-by: Zhuhe Fang <[email protected]>
wanpengfei-git
pushed a commit
to fzhedu/starrocks
that referenced
this pull request
Mar 22, 2023
… more than one times (StarRocks#19843) --------- Signed-off-by: Zhuhe Fang <[email protected]>
Seaven
pushed a commit
that referenced
this pull request
Mar 22, 2023
… more than one times (#19843) (#19903) --------- Signed-off-by: Zhuhe Fang <[email protected]>
andyziye
pushed a commit
to fzhedu/starrocks
that referenced
this pull request
Mar 27, 2023
… more than one times (StarRocks#19843) --------- Signed-off-by: Zhuhe Fang <[email protected]>
Seaven
pushed a commit
that referenced
this pull request
Mar 27, 2023
… more than one times (#19843) (#19902) --------- Signed-off-by: Zhuhe Fang <[email protected]>
numbernumberone
pushed a commit
to numbernumberone/starrocks
that referenced
this pull request
May 31, 2023
… more than one times (StarRocks#19843) --------- Signed-off-by: Zhuhe Fang <[email protected]>
abc982627271
pushed a commit
to abc982627271/starrocks
that referenced
this pull request
Jun 5, 2023
… more than one times (StarRocks#19843) --------- Signed-off-by: Zhuhe Fang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this：
Which issues of this PR fixes ：
Fixes ##19392
Problem Summary(Required) ：
To avoid the ids of lambda arguments are different after each visit(), previously SqlToScalarOperatorTranslator transform lambda functions only once. so if transform it more than one times, the previously allocated ids for captured columns cannot be recognized later in CTE transform.
now fix that by remembering transformed columnRef in lambda arguments.
Checklist:
Bugfix cherry-pick branch check: