[BugFix] Fix StatefulSet Update Strategy Handling #616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed unnecessary quotes around `maxUnavailable` in `starrockscluster.yaml` to ensure proper YAML parsing and value interpretation. - Added `updateStrategy` to the `hashStatefulsetObject` struct in `statefulset.go` to include update strategy in the hash calculation. Signed-off-by: yandongxiao <[email protected]>
yandongxiao
force-pushed
the
bugfix/update-strategy-of-sts
branch
from
51d9ba7 to
b9b830a
Compare
dengliu
approved these changes
Jan 17, 2025
kevincai
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
maxUnavailableinstarrockscluster.yamlto ensure proper YAML parsing and value interpretation.updateStrategyto thehashStatefulsetObjectstruct instatefulset.goto include update strategy in the hash calculation.Fixes #615
Checklist
For operator, please complete the following checklist:
make generateto generate the code.golangci-lint runto check the code style.make testto run UT.make manifeststo update the yaml files of CRD.For helm chart, please complete the following checklist:
file of starrocks chart.
scriptsdirectory, runbash create-parent-chart-values.shto update the values.yaml file of the parentchart( kube-starrocks chart).