[BugFix] Fix StatefulSet Update Strategy Handling

 - Removed unnecessary quotes around `maxUnavailable` in `starrockscluster.yaml` to ensure proper YAML parsing and value interpretation.
 - Added `updateStrategy` to the `hashStatefulsetObject` struct in `statefulset.go` to include update strategy in the hash calculation.

Signed-off-by: yandongxiao <[email protected]>

Author: yandongxiao

helm-charts/charts/kube-starrocks/charts/starrocks/templates/starrockscluster.yaml

@@ -30,7 +30,7 @@ spec:
     {{- if .Values.starrocksFESpec.maxUnavailablePods }}
     updateStrategy:
       rollingUpdate:
-        maxUnavailable: "{{ .Values.starrocksFESpec.maxUnavailablePods }}"
+        maxUnavailable: {{ .Values.starrocksFESpec.maxUnavailablePods }}
     {{- end }}
     {{- /*
     support both resources and resource for backward compatibility
@@ -277,7 +277,7 @@ spec:
     {{- if .Values.starrocksBeSpec.maxUnavailablePods }}
     updateStrategy:
       rollingUpdate:
-        maxUnavailable: "{{ .Values.starrocksBeSpec.maxUnavailablePods }}"
+        maxUnavailable: {{ .Values.starrocksBeSpec.maxUnavailablePods }}
     {{- end }}
     {{- /*
     support both resources and resource for backward compatibility
@@ -556,7 +556,7 @@ spec:
     {{- if .Values.starrocksCnSpec.maxUnavailablePods }}
     updateStrategy:
       rollingUpdate:
-        maxUnavailable: "{{ .Values.starrocksCnSpec.maxUnavailablePods }}"
+        maxUnavailable: {{ .Values.starrocksCnSpec.maxUnavailablePods }}
     {{- end }}
     {{- if or .Values.starrocksCnSpec.serviceAccount .Values.starrocksCluster.componentValues.serviceAccount }}
     serviceAccount: {{ include "starrockscluster.cn.serviceAccount" . }}

pkg/common/resource_utils/statefulset.go

@@ -34,6 +34,7 @@ type hashStatefulsetObject struct {
 	serviceName          string
 	volumeClaimTemplates []corev1.PersistentVolumeClaim
 	replicas             int32
+	updateStrategy       appv1.StatefulSetUpdateStrategy
 }
 
 // StatefulsetHashObject construct the hash spec for deep equals to exist statefulset.
@@ -60,6 +61,7 @@ func statefulSetHashObject(sts *appv1.StatefulSet, excludeReplica bool) hashStat
 		serviceName:          sts.Spec.ServiceName,
 		volumeClaimTemplates: sts.Spec.VolumeClaimTemplates,
 		replicas:             replicas,
+		updateStrategy:       sts.Spec.UpdateStrategy,
 	}
 }
 
@@ -91,8 +93,7 @@ func StatefulSetDeepEqual(new *appv1.StatefulSet, old *appv1.StatefulSet, exclud
 
 	// avoid the update from kubectl.
 	return newHashv == oldHashv &&
-		new.Namespace == old.Namespace /* &&
-		oldGeneration == old.Generation*/
+		new.Namespace == old.Namespace
 }
 
 // MergeStatefulSets merge exist statefulset and new statefulset.