Upgrade pants from 2.16.0a0 to 2.16.0rc0 #5950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/XXL
cognifloyd
commented
Mar 31, 2023
There was a problem hiding this comment.
We are using BUILD, and as a general rule using only that is good. Pants supports BUILD.*, and I think it helped to cleanly separate concerns between BUILD (for our code) and BUILD.tools (for the tools resolves/requirements).
cognifloyd
force-pushed
the
pants-upgrade-2.16
branch
2 times, most recently
from
5b5ee7e
to
4026143
Compare
cognifloyd
changed the title
Lockfile diff: lockfiles/pants-plugins.lock [pants-plugins] == Upgraded dependencies == importlib-metadata 6.0.0 --> 6.1.0 pantsbuild-pants 2.16.0a0 --> 2.16.0rc0 pantsbuild-pants-testutil 2.16.0a0 --> 2.16.0rc0 pex 2.1.126 --> 2.1.130
We create new resolves for each tool instead of using the implicit tool resolve which has been deprecated. Now all of the tool requirements are defined in //BUILD.tools instead of //pants.toml lockfile regen will go in the next commit.
Lockfile diff: lockfiles/black.lock [black] == Upgraded dependencies == mypy-extensions 0.4.3 --> 1.0.0 Lockfile diff: lockfiles/bandit.lock [bandit] == Upgraded dependencies == pbr 5.11 --> 5.11.1 Lockfile diff: lockfiles/twine.lock [twine] == Upgraded dependencies == cryptography 38.0.4 --> 40.0.1 pkginfo 1.9.2 --> 1.9.6 pygments 2.13 --> 2.14.0 urllib3 1.26.13 --> 1.26.15 == !! Downgraded dependencies !! == bleach 5.0.1 --> 4.1.0 charset-normalizer 2.1.1 --> 2.0.12 colorama 0.4.6 --> 0.4.5 docutils 0.19 --> 0.18.1 importlib-metadata 5.1 --> 4.8.3 jeepney 0.8 --> 0.7.1 keyring 23.11 --> 23.4.1 readme-renderer 37.3 --> 34.0 requests 2.28.1 --> 2.27.1 rfc3986 2 --> 1.5.0 typing-extensions 4.4 --> 4.1.1 zipp 3.11 --> 3.6.0 == Added dependencies == importlib-resources 5.4.0 packaging 21.3 pyparsing 3.0.7 == Removed dependencies == jaraco-classes 3.2.3 more-itertools 9 Lockfile diff: lockfiles/pytest.lock [pytest] == Upgraded dependencies == attrs 22.1 --> 22.2.0 icdiff 2.0.5 --> 2.0.6 pygments 2.13 --> 2.14.0
cognifloyd
force-pushed
the
pants-upgrade-2.16
branch
from
4026143
to
d2ff05b
Compare
cognifloyd
requested review from
winem,
arm4b,
nzlosh,
rush-skills,
amanda11 and
a team
amanda11
approved these changes
Apr 13, 2023
nzlosh
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on:
This is a follow-up for:
See that issue for details about other changes that we have already adjusted to in pants 2.16.
A significant change landed between 2.16.0a0 and 2.16.0rc0: tool (black, flake8, pytest, etc) lockfiles were refactored so that and some of the old options used to populate them were deprecated. We could use 2.16 without regenerating the lockfiles, but the deprecation notices are noisy and using the refactored lockfiles feels more consistent.
Now, instead of defining tool versions in
pants.toml, where we had to duplicate those versions in some BUILD files likepylint_plugins/BUILD, we can now have a use BUILD files as the single source of truth for all tool versions. To keep the root BUILD file from getting large and unweildy, I used a newBUILD.toolslockfile to store all of these tool versions.Another benefit of this upgrade is: There is no difference between "tool" and "user" lockfiles now. That means we only have one
pylintresolve+lockfile instead ofpylint(for the tool) andpylint_plugins(for our in-repo plugin code).Summary of lockfile changes
copied from the commit descriptions