Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pants: pin versions of pip and setuptools #5949

Merged
merged 3 commits into from
Apr 11, 2023
Merged

pants: pin versions of pip and setuptools #5949

merged 3 commits into from
Apr 11, 2023

Conversation

cognifloyd
Copy link
Member

@cognifloyd cognifloyd commented Mar 31, 2023 •
edited
Loading

I had some issues with the virtualenvs that pants created containing the wrong version of pip and setuptools. So, this PR does the following:

  • bump the version of pex to include an upstream fix that was using the default version instead of the locked version of pip+setuptools
  • add pip and setuptools to requirements-pants.txt
  • regenerate the lockfile to include them
  • added some explicit BUILD dependencies to make sure the pip and virtualenv command line utils are available in the st2 virtualenv.

@cognifloyd cognifloyd self-assigned this Mar 31, 2023
@pull-request-size pull-request-size bot added the size/L PR that changes 100-499 lines. Requires some effort to review. label Mar 31, 2023
@cognifloyd cognifloyd added this to the pants milestone Mar 31, 2023
@cognifloyd cognifloyd mentioned this pull request Mar 31, 2023
Merged
@cognifloyd
pants: use newer version of pex to fix lockfile regen and virutalenv …
346a29b 
…export
@cognifloyd
chore: add explicit BUILD dependencies on virtualenv, pip, wheel
a9974af 
Lockfile diff: lockfiles/st2.lock [st2]

==                    Upgraded dependencies                     ==

  argcomplete                    2.1.1        -->   3.0.5
  beautifulsoup4                 4.11.2       -->   4.12.0
  cryptography                   39.0.2       -->   40.0.1
  httplib2                       0.21.0       -->   0.22.0
  pytz                           2022.7.1     -->   2023.3
  redis                          4.3.5        -->   4.3.6
  tzdata                         2022.7       -->   2023.3

==                      Added dependencies                      ==

  pip                            21.3.1
  wheel                          0.37.1
@cognifloyd
update changelog entry
d688eba
@cognifloyd cognifloyd requested a review from a team March 31, 2023 16:22
@cognifloyd cognifloyd merged commit 78c66f2 into master Apr 11, 2023
@cognifloyd cognifloyd deleted the pants-venv-pip branch April 11, 2023 17:02
@cognifloyd cognifloyd mentioned this pull request Apr 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arm4b arm4b arm4b approved these changes

@amanda11 amanda11 amanda11 approved these changes

@winem winem Awaiting requested review from winem

@nzlosh nzlosh Awaiting requested review from nzlosh

@rush-skills rush-skills Awaiting requested review from rush-skills

Assignees

@cognifloyd cognifloyd

Labels
external dependency pantsbuild size/L PR that changes 100-499 lines. Requires some effort to review.
Projects
None yet
Milestone
pants
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cognifloyd @arm4b @amanda11