-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop duplicated dependencies from pom.xml
#182
Conversation
Codecov Report
@@ Coverage Diff @@
## master #182 +/- ##
=========================================
Coverage 64.71% 64.71%
Complexity 232 232
=========================================
Files 77 77
Lines 2327 2327
Branches 48 48
=========================================
Hits 1506 1506
Misses 803 803
Partials 18 18 |
@armiol Please take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take care of the memory consumption. Also, we need to check if the published documentation is fine. You may publish this locally to inspect the artifacts.
@armiol PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This PR addresses #362.
In particular, it does the following:
pmd
plugin, which is now applied via ourpmd-settings
script. It eliminates duplicated dependencies onpmd
.config
which contains a fix for the issue. It hides duplicated dependencies onprotoc
, emitting a warning.dokkaJar
artifact.Additionally,
J2ObjC.lib
was replaced withJ2ObjC.annotations
, as the former is deprecated:Please note, when pulling the latest
config
, the versions of some libraries have been preserved as they were:2.10.0
due to Bump the versions of Spine libraries #181.1.4.0
due to Bump the versions of Spine libraries #181.3.19.4
due to Bump the version of Protobuf #183.The library version is bumped to
2.0.0-SNAPSHOT.74
.