-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter out duplicated dependencies from pom.xml
#368
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@armiol @alexander-yevsyukov Please, take a look. |
armiol
requested changes
Apr 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please log some details on the duplicates, as we discussed.
@armiol PTAL |
armiol
approved these changes
May 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This was referenced May 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #362.
As described in the issue, sometimes we can't overcome the presence of several versions of the same dependency.
pom.xml
is generated upon a whole project and doesn't group dependencies by modules. Specific modules override versions dictated byconfig
. And, as a result, several versions of the same dependency leak topom.xml
.spine-time
repository is an example here. Each subproject is configured to use a specific version ofprotoc
fromconfig
. The configuration is performed from the root project:Meanwhile,
time
module applies ourmc-java
plugin, and not the last version. The plugin overrides the version ofprotoc
, specified by the root. As a result, the module uses its own version.This PR makes
DependencyWriter
filter out duplicates by group and name. Only the one, with the newest version, is retained. The duplicates are logged.Generation of license reports is not changed, since dependencies there are grouped by modules.