Bug: S1125 code fix does not add ! when transforming x == false.#8945
Merged
gregory-paidis-sonarsource merged 2 commits intomasterfrom Mar 20, 2024
Merged
Bug: S1125 code fix does not add ! when transforming x == false.#8945gregory-paidis-sonarsource merged 2 commits intomasterfrom
gregory-paidis-sonarsource merged 2 commits intomasterfrom
Conversation
analyzers/src/SonarAnalyzer.CSharp/Rules/BooleanLiteralUnnecessaryCodeFix.cs
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.Test/TestCases/BooleanLiteralUnnecessary.Fixed.cs
Show resolved
Hide resolved
| if (false != cond) { } // Noncompliant | ||
|
|
||
| if (true == cond) { } // Noncompliant | ||
| if (true != cond) { } // Noncompliant |
Contributor
Author
There was a problem hiding this comment.
6/8 of these are not impacted, only x == false and false == x has special parsing.
I added all of them because they are best friends and like to hang out together (and I wanted to make sure I did not break them).
analyzers/src/SonarAnalyzer.CSharp/Rules/BooleanLiteralUnnecessaryCodeFix.cs
Outdated
Show resolved
Hide resolved
costin-zaharia-sonarsource
approved these changes
Mar 19, 2024
Member
costin-zaharia-sonarsource
left a comment
costin-zaharia-sonarsource
left a comment
There was a problem hiding this comment.
LGTM! Please change the regions with comments.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7999