Bug: S1125 code fix does not add ! when transforming x == false.

[urmel9]

• Operating system: Microsoft Visual Studio Community 2022 (64-Bit) - Current
  Version 17.7.0
• SonarLint plugin version: 9.8.0.76515
• Programming language you're coding in: C#
• Is connected mode used: No
• Link to SonarCommunity

Hello,
we use SonarLint with StyleCop in our company. Because there are many small warning that could be autofixed on save, we use the feature "clean-code on save".

Here is the problem:
The Autofix of S1125 is wrong. The rule and the description are definitely correct, but the autofix function is wrong. It changes if (testBool == false) to if (testBool). Screenshot are attached.

This is the fix:
Autofix should have this result:
if (!testBool)

We had some bugs because SonarLint changed it wrong and is missing the exclamation mark on negative boolean literals. Could you please fix this? We will use the rule quick then again. Thank you! :slight_smile:

Before:

After clean-code on save

[mary-georgiou-sonarsource]

Hello @urmel9 and thanks for your report.
I confirm this is a bug.
I added this issue to our backlog to tackle as soon as we can.

[urmel9]

Hello @mary-georgiou-sonarsource are there any updates about this? Is it fixed now, or do I have to wait until the next release?
Thank you! :)

[mary-georgiou-sonarsource]

Hello, @urmel9!
Not yet - we need to plan to fix this during a future sprint.
Please follow the issue so you'll be updated once it's fixed!

[msedi]

@mary-georgiou-sonarsource @pavel-mikula-sonarsource Just a question, why has the Bug label be removed? I think it is a bug, right?

[urmel9]

@msedi I agree. It is unexpected behavior and leads to bug in your own code, when you use autoformat. Even the sugestion is confusing.

[mary-georgiou-sonarsource]

We use the bug label only for issues related to one of our analyzers throwing AD0001- NullReferenceException.

Edit: you can find the label descriptions here https://github.com/SonarSource/sonar-dotnet/labels

[HipDragon]

Any idea of when this will be fixed?

It would be nice if this autofix was disabled while this was being resolved. Better to leave the code alone and working as developers originally wrote it. Then to have developers tempted to use the autofix and have it possibility change the logic of the code.

If there is a way to disable specific autofixes in SonarLint I would like to know. Thanks in advance.