Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update S1186: Change expcetion type in RPSEC #7587

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Update S1186: Change expcetion type in RPSEC #7587

merged 1 commit into from
Jul 31, 2023

Conversation

nalka0
Copy link
Contributor

@nalka0 nalka0 commented Jul 12, 2023

Fixes a (likely) NotSupportedException copy paste mistake on S1186's html documentation

@zsolt-kolbay-sonarsource
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource marked this pull request as ready for review July 28, 2023 06:26
@sonarcloud
Copy link

sonarcloud bot commented Jul 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Jul 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
You have sharp eyes @nalka0, thank you for fixing this small mistake.
I've added a fix to the RSPEC document so the two don't get out of sync. I'll merge both PRs when that gets approved.

gregory-paidis-sonarsource pushed a commit to SonarSource/rspec that referenced this pull request Jul 31, 2023
@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource merged commit 4b25ebc into SonarSource:master Jul 31, 2023
25 checks passed
@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource changed the title Fix copy paste in S1186 docs Update S1186: Change expcetion type in RPSEC Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants