Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify rule S1186: Fix exception type #2694

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Modify rule S1186: Fix exception type #2694

merged 1 commit into from
Jul 31, 2023

Conversation

zsolt-kolbay-sonarsource
Copy link
Contributor

@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource commented Jul 28, 2023 •
edited
Loading

Related to this community PR.

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@sonarqube-next
Copy link

SonarQube Quality Gate for 'rspec-frontend'

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqube-next
Copy link

SonarQube Quality Gate for 'rspec-tools'

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@necto necto changed the title Modify S1186: Fix exception type Modify rule S1186: Fix exception type Jul 31, 2023
gregory-paidis-sonarsource
gregory-paidis-sonarsource approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gregory-paidis-sonarsource gregory-paidis-sonarsource merged commit ed26048 into master Jul 31, 2023
8 checks passed
@gregory-paidis-sonarsource gregory-paidis-sonarsource deleted the Zsolt/S1186-NotImplementedException branch July 31, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregory-paidis-sonarsource gregory-paidis-sonarsource gregory-paidis-sonarsource approved these changes

@sebastien-marichal sebastien-marichal Awaiting requested review from sebastien-marichal

@antonioaversa antonioaversa Awaiting requested review from antonioaversa

Assignees
No one assigned
Labels
dotnet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zsolt-kolbay-sonarsource @gregory-paidis-sonarsource