Skip to content

Create rule S2629: Add C# and VbNet #2509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zsolt-kolbay-sonarsource merged 13 commits into from
Feb 22, 2024
Merged

Create rule S2629: Add C# and VbNet #2509

zsolt-kolbay-sonarsource merged 13 commits into from
Feb 22, 2024

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jul 17, 2023

You can preview this rule here (updated a few minutes after each push).

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@csaba-sagi-sonarsource csaba-sagi-sonarsource changed the title Create rule S2629 Create rule S2629: Add C# Jul 18, 2023
cristian-ambrosini-sonarsource
cristian-ambrosini-sonarsource suggested changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@cristian-ambrosini-sonarsource cristian-ambrosini-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments

@cristian-ambrosini-sonarsource
Copy link
Contributor

cristian-ambrosini-sonarsource commented Jul 18, 2023

Now that you specified the rule for VBNET as well please remember to change the title of the PR.

@csaba-sagi-sonarsource csaba-sagi-sonarsource changed the title Create rule S2629: Add C# Create rule S2629: Add C# and VbNet Jul 19, 2023
cristian-ambrosini-sonarsource
cristian-ambrosini-sonarsource approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@cristian-ambrosini-sonarsource cristian-ambrosini-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I left 2 optional suggestions

@sonarqube-next
Copy link

sonarqube-next bot commented Jul 20, 2023

SonarQube Quality Gate for 'rspec-tools'

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqube-next
Copy link

sonarqube-next bot commented Jul 20, 2023

SonarQube Quality Gate for 'rspec-frontend'

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@costin-zaharia-sonarsource costin-zaharia-sonarsource mentioned this pull request Feb 16, 2024
Closed
@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource mentioned this pull request Feb 21, 2024
Merged
@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource marked this pull request as ready for review February 22, 2024 17:46
@sonarqube-next
Copy link

sonarqube-next bot commented Feb 22, 2024

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@sonarqube-next
Copy link

sonarqube-next bot commented Feb 22, 2024

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource merged commit 0b9652d into master Feb 22, 2024
@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource deleted the rule/S2629-add-csharp branch February 22, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@csaba-sagi-sonarsource csaba-sagi-sonarsource csaba-sagi-sonarsource left review comments

@cristian-ambrosini-sonarsource cristian-ambrosini-sonarsource cristian-ambrosini-sonarsource approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@csaba-sagi-sonarsource csaba-sagi-sonarsource

Labels

dotnet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cristian-ambrosini-sonarsource @csaba-sagi-sonarsource @zsolt-kolbay-sonarsource