New Rule S2629: Logging templates should be constant

[zsolt-kolbay-sonarsource]

Fixes #8768
Deviations from the original RSPEC:

• no check is done for the exception on InterpolatedStringHandlerAttribute. While the exception sounds reasonable, none of the logging frameworks use it. It's only mentioned in a proposal in the Serilog repo, which was rejected.
• in addition to string interpolation, string.Format() is also checked

[costin-zaharia-sonarsource]

no check is done for the exception on InterpolatedStringHandlerAttribute as I couldn't find any logging method that use this attribute

My understanding is that the attribute is declared on the type of the argument that is passed to the logging method invocation. It's not about the logging method. https://learn.microsoft.com/en-us/dotnet/csharp/whats-new/tutorials/interpolated-string-handler

[costin-zaharia-sonarsource]

Looks good to me so far. I've added a couple of questions and I'm waiting for the RSPEC update.

[costin-zaharia-sonarsource]

LGTM! Just a small change needed before I approve

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud