Skip to content

Conversation

@alistair-singh
Copy link
Contributor

@alistair-singh alistair-singh commented Mar 9, 2022

Resolves: SNO-198

Notable Changes

Require MaxEncodedLen per default

paritytech/substrate#10662

  • I have added the attribute without_storage_info to pallets which cannot implement MaxEncodedLen yet. This is a non trivial change to make as we have to change code to use BoundedVec and to check bounds.
  • Added ticket to address this. Related: SNO-223

Remove Default bound for AccountId

paritytech/substrate#10403

  • The zero account is no longer the default as it poses potential risks around external callers using the zero account to gain privileges based on zero account being used as default in the code base.
  • I have switched to using Optional<AccountId> in pallets.
  • XCM config uses ParentIsPreset as opposed to ParentIsDefault.
  • Added CheckNonZeroSender as a signed extension to filter out zero accounts.

Switch from StructOps to Clap for arg parsing

https://github.com/substrate-developer-hub/substrate-parachain-template/pull/101

  • The substrate parachain node template now uses clap for args parsing. I have removed StructOps to keep some symmetry with the project to make future upgrades easier.

Updated Workflow Toolchains

  • Updated to stable-2022-01-20 (1.58.1)
  • This is to support the edition 2021 required by the snowbridge-test-collator

Allow unpaid execution from relay chain or relay chain executive.

https://github.com/substrate-developer-hub/substrate-parachain-template/pull/80

  • Changed the XCM config to allow unpaid execution for the relay chain or it's executive. Previously this was set to Unit.

E2E Tests

Currently e2e tests are failing from the parachain -> ethereum direction. This is because of an update to the BEEFY included in v0.9.17 version of polkadot. The beefy light client and relayer will need to be updated.

@alistair-singh alistair-singh force-pushed the alistair/update-to-0.9.17 branch 3 times, most recently from 8cc5cb0 to 85cabcc Compare March 15, 2022 20:25
@alistair-singh alistair-singh marked this pull request as ready for review March 16, 2022 09:37
@alistair-singh alistair-singh requested a review from vgeddes March 16, 2022 09:39
@alistair-singh alistair-singh force-pushed the alistair/update-to-0.9.17 branch from 543f11a to 8cf40db Compare March 17, 2022 13:42
@alistair-singh alistair-singh force-pushed the alistair/update-to-0.9.17 branch from 8cf40db to b720804 Compare March 19, 2022 10:46
@claravanstaden claravanstaden mentioned this pull request Mar 22, 2022
@vgeddes vgeddes changed the base branch from main to polkadot-0.9.17 March 28, 2022 12:46
Copy link
Collaborator

@vgeddes vgeddes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vgeddes vgeddes merged commit 860982e into polkadot-0.9.17 Mar 28, 2022
@vgeddes vgeddes deleted the alistair/update-to-0.9.17 branch March 28, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants